Build browser_main_loop.cc on iOS.

Build browser_main_loop.cc on iOS.

Adds browser_main_loop.cc to the build on iOS and ifdefs out the parts that are
not supported on iOS.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161362

[msarda, 2012-10-08 13:53:57]

PTAL.

[stuartmorgan, 2012-10-08 13:59:38]

LGTM with nit.
+jam for OWNERS (these are new dependencies that came in since the earlier
patch, since we weren't building for iOS yet)

https://chromiumcodereview.appspot.com/11087007/diff/1/content/browser/browse...
File content/browser/browser_main_loop.cc (right):

https://chromiumcodereview.appspot.com/11087007/diff/1/content/browser/browse...
content/browser/browser_main_loop.cc:682: #if !defined(OS_IOS)
Move this up to the beginning of the block (just before // Alert the clipboard
[...]) since it's all conceptually linked.

[msarda, 2012-10-08 14:05:39]

https://chromiumcodereview.appspot.com/11087007/diff/1/content/browser/browse...
File content/browser/browser_main_loop.cc (right):

https://chromiumcodereview.appspot.com/11087007/diff/1/content/browser/browse...
content/browser/browser_main_loop.cc:682: #if !defined(OS_IOS)
On 2012/10/08 13:59:39, stuartmorgan wrote:
> Move this up to the beginning of the block (just before // Alert the clipboard
> [...]) since it's all conceptually linked.

Done.

[jam, 2012-10-10 04:06:49]

lgtm

[commit-bot: I haz the power, 2012-10-11 09:17:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msarda@chromium.org/11087007/4001

[commit-bot: I haz the power, 2012-10-11 09:17:47]

Failed to apply patch for content/content_browser.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/content_browser.gypi
  Hunk #1 FAILED at 872.
  1 out of 1 hunk FAILED -- saving rejects to file
content/content_browser.gypi.rej

Patch:       content/content_browser.gypi
Index: content/content_browser.gypi
diff --git a/content/content_browser.gypi b/content/content_browser.gypi
index
5c127f5bd6ad30f600f7fd990351de74738a9875..186e8cac41316b03888634a922058f99276c5cfe
100644
--- a/content/content_browser.gypi
+++ b/content/content_browser.gypi
@@ -872,6 +872,7 @@
         ['include', '^public/browser/notification_registrar\\.cc$'],
         ['include', '^public/browser/speech_recognition_'],
         ['include', '^browser/browser_context\\.cc$'],
+        ['include', '^browser/browser_main_loop\\.cc$'],
         ['include', '^browser/notification_service_impl\\.cc$'],
       ],
     }, {  # OS!="ios"

[commit-bot: I haz the power, 2012-10-11 14:30:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msarda@chromium.org/11087007/10002

[commit-bot: I haz the power, 2012-10-11 17:05:32]

Change committed as 161362