Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 11087003: Remove NOTIMPLEMENTED in shell_web_contents_view_delegate to avoid log spew. (Closed)

Created:
8 years, 2 months ago by Shouqun Liu
Modified:
8 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove NOTIMPLEMENTED in shell_web_contents_view_delegate to avoid log spew. BUG=154251 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/shell/shell_web_contents_view_delegate_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Shouqun Liu
8 years, 2 months ago (2012-10-08 11:44:42 UTC) #1
jam
lgtm
8 years, 2 months ago (2012-10-10 04:02:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/11087003/1
8 years, 2 months ago (2012-10-10 04:26:33 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 2 months ago (2012-10-10 04:32:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/11087003/1
8 years, 2 months ago (2012-10-10 08:30:42 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-10 12:28:46 UTC) #6
Change committed as 161093

Powered by Google App Engine
This is Rietveld 408576698