Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 11086069: Add missing python-mod-pywebsocket dependency to install-build-deps.sh (Closed)

Created:
8 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 2 months ago
Reviewers:
Ryan Sleevi, marja
CC:
chromium-reviews
Visibility:
Public.

Description

Add missing python-mod-pywebsocket dependency to install-build-deps.sh This is required after 160782 to run the testserver BUG=137639 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/install-build-deps.sh View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
plz review
8 years, 2 months ago (2012-10-11 09:23:32 UTC) #1
marja
lgtm
8 years, 2 months ago (2012-10-11 11:39:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11086069/1
8 years, 2 months ago (2012-10-11 11:46:36 UTC) #3
commit-bot: I haz the power
Change committed as 161344
8 years, 2 months ago (2012-10-11 14:48:00 UTC) #4
Ryan Sleevi
NACK - I believe this should be reverted. It is intended that the pywebsocket dependency ...
8 years, 2 months ago (2012-10-11 15:26:04 UTC) #5
jochen (gone - plz use gerrit)
well, then it doesn't work. I can't run browser_tests without installing it manually :-./ On ...
8 years, 2 months ago (2012-10-11 15:28:37 UTC) #6
Takashi Toyoshima
8 years, 2 months ago (2012-10-11 16:01:02 UTC) #7
Hi, this change was wrong.
We use trunk version of pywebsocket which exists in third_party/pywebsocket.
System provided library doesn't work.

Powered by Google App Engine
This is Rietveld 408576698