Browser Plugin: When Guest crashes Embedder crashes in content shell

Browser Plugin: When Guest crashes Embedder crashes in content shell

content_shell does not have the sad plugin asset. On crash, we attempt to
paint the sad plugin asset without verifying whether or not it's available.

In this patch we do that check. If it is not available we paint black instead.

As a small added bonus, this patch introduces the small optimization of destroying
the backing store when the guest crashes because we have no need of it. Subsequent
navigations will request a new backing store anyway.

BUG=155059
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161162

[sadrul, 2012-10-10 15:40:29]

BUG=155059

LGTM

[Fady Samuel, 2012-10-10 15:42:02]

+creis@ for OWNER review.

[Fady Samuel, 2012-10-10 15:42:03]

+creis@ for OWNER review.

[Charlie Reis, 2012-10-10 16:37:39]

Great, LGTM.

http://codereview.chromium.org/11085044/diff/1/content/renderer/browser_plugi...
File content/renderer/browser_plugin/browser_plugin.cc (right):

http://codereview.chromium.org/11085044/diff/1/content/renderer/browser_plugi...
content/renderer/browser_plugin/browser_plugin.cc:550: // Paint white in case we
have nothing in our backing store or we need to
nit: white or black

[commit-bot: I haz the power, 2012-10-10 17:43:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11085044/6002

[commit-bot: I haz the power, 2012-10-10 19:53:02]

Change committed as 161162