chrome/browser/extensions/updater/extension_downloader.cc - Issue 11085026: Don't group packaged apps in with TYPE_UNKNOWN for update check histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_downloader.cc

Issue 11085026: Don't group packaged apps in with TYPE_UNKNOWN for update check histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/updater/extension_downloader.cc

diff --git a/chrome/browser/extensions/updater/extension_downloader.cc b/chrome/browser/extensions/updater/extension_downloader.cc

index 80d5de15e0c9a9a72bd2e44e658e33bbe3d1c40e..24306bc3cc985264449d6e0374206eb0ffdaa684 100644

--- a/chrome/browser/extensions/updater/extension_downloader.cc

+++ b/chrome/browser/extensions/updater/extension_downloader.cc

@@ -239,6 +239,9 @@ bool ExtensionDownloader::AddExtensionData(const std::string& id,

case Extension::TYPE_LEGACY_PACKAGED_APP:

++url_stats_.app_count;

break;

+ case Extension::TYPE_PLATFORM_APP:

+ ++url_stats_.platform_app_count;

+ break;

case Extension::TYPE_UNKNOWN:

default:

++url_stats_.pending_count;

@@ -302,6 +305,8 @@ void ExtensionDownloader::ReportStats() const {

url_stats_.theme_count);

UMA_HISTOGRAM_COUNTS_100("Extensions.UpdateCheckApp",

url_stats_.app_count);

+ UMA_HISTOGRAM_COUNTS_100("Extensions.UpdateCheckPackagedApp",

+ url_stats_.platform_app_count);

UMA_HISTOGRAM_COUNTS_100("Extensions.UpdateCheckPending",

url_stats_.pending_count);

UMA_HISTOGRAM_COUNTS_100("Extensions.UpdateCheckGoogleUrl",

« no previous file with comments | « chrome/browser/extensions/updater/extension_downloader.h ('k') | no next file » | no next file with comments »