Issue 11085022: cros: Fix Open downloads folder opening in back

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11085022: cros: Fix Open downloads folder opening in back (Closed)

Created:
8 years, 2 months ago by James Cook

Modified:
8 years, 2 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, asanka, arv (Not doing code reviews), Randy Smith (Not in Mondays)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

cros: Fix Open downloads folder opening in back The "Open downloads folder" and "Clear all" links on the downloads page had href="" instead of href="#", which was cause an extraneous page reload when clicked. Chrome OS uses a browser window with a component extension for its file manager, so there was a focus/window activation race between that window opening and the primary browser window reasserting its activation status. Other links in the downloads page use href="#" so make the two at the top consistent. BUG=138286 TEST=manual, download a couple files, click "Open downloads folder", window should appear in front. Click "Clear all" and list should be cleared. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161147