Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11346)

Unified Diff: content/browser/renderer_host/dip_util.cc

Issue 11081007: Remove implicit flooring Scale() method from Point and Size. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/dip_util.cc
diff --git a/content/browser/renderer_host/dip_util.cc b/content/browser/renderer_host/dip_util.cc
index 191e1de3b4e1fdcaee86a7832ef17dd9322b4d31..741ce3c41c406c545c40f9e80f446fb1c98f65f1 100644
--- a/content/browser/renderer_host/dip_util.cc
+++ b/content/browser/renderer_host/dip_util.cc
@@ -7,9 +7,11 @@
#include "content/public/browser/render_widget_host_view.h"
#include "ui/gfx/display.h"
#include "ui/gfx/point.h"
+#include "ui/gfx/point_conversions.h"
#include "ui/gfx/rect.h"
#include "ui/gfx/screen.h"
#include "ui/gfx/size.h"
+#include "ui/gfx/size_conversions.h"
namespace {
@@ -27,36 +29,38 @@ ui::ScaleFactor GetScaleFactorForView(const RenderWidgetHostView* view) {
gfx::Point ConvertPointToDIP(const RenderWidgetHostView* view,
const gfx::Point& point_in_pixel) {
- return point_in_pixel.Scale(1.0f / GetScaleForView(view));
+ return gfx::ToFlooredPoint(
+ point_in_pixel.Scale(1.0f / GetScaleForView(view)));
}
gfx::Size ConvertSizeToDIP(const RenderWidgetHostView* view,
const gfx::Size& size_in_pixel) {
- return size_in_pixel.Scale(1.0f / GetScaleForView(view));
+ return gfx::ToFlooredSize(
+ size_in_pixel.Scale(1.0f / GetScaleForView(view)));
}
gfx::Rect ConvertRectToDIP(const RenderWidgetHostView* view,
const gfx::Rect& rect_in_pixel) {
float scale = 1.0f / GetScaleForView(view);
- return gfx::Rect(rect_in_pixel.origin().Scale(scale),
- rect_in_pixel.size().Scale(scale));
+ return gfx::Rect(gfx::ToFlooredPoint(rect_in_pixel.origin().Scale(scale)),
+ gfx::ToFlooredSize(rect_in_pixel.size().Scale(scale)));
}
gfx::Point ConvertPointToPixel(const RenderWidgetHostView* view,
const gfx::Point& point_in_dip) {
- return point_in_dip.Scale(GetScaleForView(view));
+ return gfx::ToFlooredPoint(point_in_dip.Scale(GetScaleForView(view)));
}
gfx::Size ConvertSizeToPixel(const RenderWidgetHostView* view,
const gfx::Size& size_in_dip) {
- return size_in_dip.Scale(GetScaleForView(view));
+ return gfx::ToFlooredSize(size_in_dip.Scale(GetScaleForView(view)));
}
gfx::Rect ConvertRectToPixel(const RenderWidgetHostView* view,
const gfx::Rect& rect_in_dip) {
float scale = GetScaleForView(view);
- return gfx::Rect(rect_in_dip.origin().Scale(scale),
- rect_in_dip.size().Scale(scale));
+ return gfx::Rect(gfx::ToFlooredPoint(rect_in_dip.origin().Scale(scale)),
+ gfx::ToFlooredSize(rect_in_dip.size().Scale(scale)));
}
} // namespace content
« no previous file with comments | « content/browser/renderer_host/compositing_iosurface_mac.mm ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698