Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Issue 11081003: Upstream scrollFocusedNodeIntoRect (Closed)

Created:
8 years, 2 months ago by Yusuf
Modified:
8 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Upstream scrollFocusedNodeIntoRect This upstreams scrollFocusNodeRect implementation on ContentViewCOre and hooks it to WebKit. The webkit side has already landed. BUG=136737 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160679

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit fix #

Total comments: 1

Patch Set 3 : Nit fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -4 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 8 chunks +104 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +13 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yusuf
8 years, 2 months ago (2012-10-06 00:34:56 UTC) #1
Yaron
is the compile failure because webkit changes haven't rolled into chromium? I'm not really the ...
8 years, 2 months ago (2012-10-06 01:36:40 UTC) #2
aelias_OOO_until_Jul13
LGTM. Adding brettw@ for OWNERS approval.
8 years, 2 months ago (2012-10-06 04:55:23 UTC) #3
Yusuf
On 2012/10/06 01:36:40, Yaron wrote: > is the compile failure because webkit changes haven't rolled ...
8 years, 2 months ago (2012-10-06 17:48:22 UTC) #4
Yusuf
http://codereview.chromium.org/11081003/diff/1/content/browser/android/content_view_core_impl.cc File content/browser/android/content_view_core_impl.cc (right): http://codereview.chromium.org/11081003/diff/1/content/browser/android/content_view_core_impl.cc#newcode731 content/browser/android/content_view_core_impl.cc:731: jobject obj) { On 2012/10/06 01:36:40, Yaron wrote: > ...
8 years, 2 months ago (2012-10-08 16:49:21 UTC) #5
brettw
owners lgtm http://codereview.chromium.org/11081003/diff/12001/content/browser/android/content_view_core_impl.cc File content/browser/android/content_view_core_impl.cc (right): http://codereview.chromium.org/11081003/diff/12001/content/browser/android/content_view_core_impl.cc#newcode735 content/browser/android/content_view_core_impl.cc:735: rect)); Can you just do gfx::Rect() here ...
8 years, 2 months ago (2012-10-08 17:30:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11081003/17001
8 years, 2 months ago (2012-10-08 17:39:16 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-08 19:24:21 UTC) #8
Change committed as 160679

Powered by Google App Engine
This is Rietveld 408576698