Upstream scrollFocusedNodeIntoRect

Upstream scrollFocusedNodeIntoRect

This upstreams scrollFocusNodeRect implementation on ContentViewCOre and hooks it to WebKit.
The webkit side has already landed.

BUG=136737
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160679

[Yaron, 2012-10-06 01:36:40]

is the compile failure because webkit changes haven't rolled into chromium?

I'm not really the right person to review. I can rubberstamp if you need owners
after Alex's review. You'll also need content and webkit OWNERS.

http://codereview.chromium.org/11081003/diff/1/content/browser/android/conten...
File content/browser/android/content_view_core_impl.cc (right):

http://codereview.chromium.org/11081003/diff/1/content/browser/android/conten...
content/browser/android/content_view_core_impl.cc:731: jobject obj) {
nit: indentation

[aelias_OOO_until_Jul13, 2012-10-06 04:55:23]

LGTM.  Adding brettw@ for OWNERS approval.

[Yusuf, 2012-10-06 17:48:22]

On 2012/10/06 01:36:40, Yaron wrote:
> is the compile failure because webkit changes haven't rolled into chromium?

Yes, it looks like the try bots hadn't gotten the change yet when I sent the try
job.

[Yusuf, 2012-10-08 16:49:21]

http://codereview.chromium.org/11081003/diff/1/content/browser/android/conten...
File content/browser/android/content_view_core_impl.cc (right):

http://codereview.chromium.org/11081003/diff/1/content/browser/android/conten...
content/browser/android/content_view_core_impl.cc:731: jobject obj) {
On 2012/10/06 01:36:40, Yaron wrote:
> nit: indentation

Done.

[brettw, 2012-10-08 17:30:50]

owners lgtm

http://codereview.chromium.org/11081003/diff/12001/content/browser/android/co...
File content/browser/android/content_view_core_impl.cc (right):

http://codereview.chromium.org/11081003/diff/12001/content/browser/android/co...
content/browser/android/content_view_core_impl.cc:735: rect));
Can you just do gfx::Rect() here instead of making a temporary above? It will
save a line, and the way this was I originally thought you were taking an out
param.

[commit-bot: I haz the power, 2012-10-08 17:39:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusufo@chromium.org/11081003/17001

[commit-bot: I haz the power, 2012-10-08 19:24:21]

Change committed as 160679