Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 11078018: Restored partial rasterization for AlphaBlend. (Closed)

Created:
8 years, 2 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Restored partial rasterization for AlphaBlend. Fixed incorect transformation in RasterizeAlphaBlendProc. BUG=152204 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161713

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -27 lines) Patch
M chrome/browser/printing/print_view_manager.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download
M printing/emf_win.h View 1 chunk +4 lines, -0 lines 0 comments Download
M printing/emf_win.cc View 4 chunks +128 lines, -21 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 2 months ago (2012-10-12 07:09:02 UTC) #1
gene
lgtm
8 years, 2 months ago (2012-10-12 19:40:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11078018/3007
8 years, 2 months ago (2012-10-12 19:54:49 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 2 months ago (2012-10-12 23:01:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11078018/3007
8 years, 2 months ago (2012-10-12 23:04:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11078018/15002
8 years, 2 months ago (2012-10-12 23:09:10 UTC) #6
commit-bot: I haz the power
Change committed as 161713
8 years, 2 months ago (2012-10-13 04:50:07 UTC) #7
Timur Iskhodzhanov
7 years, 9 months ago (2013-03-28 03:49:39 UTC) #8
Message was sent while issue was closed.
https://code.google.com/p/chromium/issues/detail?id=224532

https://chromiumcodereview.appspot.com/11078018/diff/15002/printing/emf_win.cc
File printing/emf_win.cc (right):

https://chromiumcodereview.appspot.com/11078018/diff/15002/printing/emf_win.c...
printing/emf_win.cc:128: ::FillRect(context_, &bitmap_rect.ToRECT(),
FYI taking an address of a temporary object is not standard C++.

Powered by Google App Engine
This is Rietveld 408576698