Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 11078015: Fix proguard logic, set proguard config only when proguard is enabled. (Closed)

Created:
8 years, 2 months ago by shashi
Modified:
8 years, 2 months ago
Reviewers:
cjhopman, Yaron, nilesh
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Fix proguard logic, set proguard config only when proguard is enabled. Even when proguard config is set to an empty string, proguard can still run, we do not want proguard to run if it is not explicitly enabled for a target. BUG=149214 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161493

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/android/ant/chromium-apk.xml View 1 2 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
shashi
8 years, 2 months ago (2012-10-12 00:31:51 UTC) #1
cjhopman
lgtm https://chromiumcodereview.appspot.com/11078015/diff/1/build/android/ant/chromium-apk.xml File build/android/ant/chromium-apk.xml (right): https://chromiumcodereview.appspot.com/11078015/diff/1/build/android/ant/chromium-apk.xml#newcode50 build/android/ant/chromium-apk.xml:50: <and> I don't think the <and> block is ...
8 years, 2 months ago (2012-10-12 00:39:56 UTC) #2
shashi
https://chromiumcodereview.appspot.com/11078015/diff/1/build/android/ant/chromium-apk.xml File build/android/ant/chromium-apk.xml (right): https://chromiumcodereview.appspot.com/11078015/diff/1/build/android/ant/chromium-apk.xml#newcode50 build/android/ant/chromium-apk.xml:50: <and> Nice catch, thanks. I had one more condition ...
8 years, 2 months ago (2012-10-12 00:48:43 UTC) #3
Yaron
lgtm https://chromiumcodereview.appspot.com/11078015/diff/6002/build/android/ant/chromium-apk.xml File build/android/ant/chromium-apk.xml (right): https://chromiumcodereview.appspot.com/11078015/diff/6002/build/android/ant/chromium-apk.xml#newcode49 build/android/ant/chromium-apk.xml:49: value="${PROGUARD_FLAGS}"> I think this fits on the line ...
8 years, 2 months ago (2012-10-12 00:49:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11078015/5002
8 years, 2 months ago (2012-10-12 00:54:46 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-12 03:44:49 UTC) #6
Change committed as 161493

Powered by Google App Engine
This is Rietveld 408576698