Adding Java style presubmit check.

Adding Java style presubmit check.

BUG=320711
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239824

[aurimas (slooooooooow), 2013-12-09 22:28:37]

Hey Newton,

Please take a look at this change.

Aurimas

[newt (away), 2013-12-10 00:04:28]

Looks good. Just need to figure out how this presubmit check can be shared with
Chrome for Android's internal presubmit.

https://chromiumcodereview.appspot.com/110773002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/110773002/diff/20001/PRESUBMIT.py#newc...
PRESUBMIT.py:982: import os
move "import" to beginning of function

https://chromiumcodereview.appspot.com/110773002/diff/20001/PRESUBMIT.py#newc...
PRESUBMIT.py:984: file_error = ('  Java checkstyle configuration file is
missing')
I'd include the path to the missing file to help people debug this error

[aurimas (slooooooooow), 2013-12-10 02:31:47]

https://chromiumcodereview.appspot.com/110773002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/110773002/diff/20001/PRESUBMIT.py#newc...
PRESUBMIT.py:984: file_error = ('  Java checkstyle configuration file is
missing')
On 2013/12/10 00:04:28, newt wrote:
> I'd include the path to the missing file to help people debug this error

Done.

[aurimas (slooooooooow), 2013-12-10 02:32:55]

+maruel please take a look at this change.

[M-A Ruel, 2013-12-10 13:26:51]

lgtm

https://chromiumcodereview.appspot.com/110773002/diff/40001/tools/android/che...
File tools/android/checkstyle/checkstyle.py (right):

https://chromiumcodereview.appspot.com/110773002/diff/40001/tools/android/che...
tools/android/checkstyle/checkstyle.py:5: """ Script that is used by
PRESUBMIT.py to run style checks on Java files."""
""Script

https://chromiumcodereview.appspot.com/110773002/diff/40001/tools/android/che...
tools/android/checkstyle/checkstyle.py:7: 
remove one empty line

https://chromiumcodereview.appspot.com/110773002/diff/40001/tools/android/che...
tools/android/checkstyle/checkstyle.py:20: if
os.path.splitext(x.LocalPath())[1].lower() == '.java']
are .JAVA files valid?

https://chromiumcodereview.appspot.com/110773002/diff/40001/tools/android/che...
tools/android/checkstyle/checkstyle.py:42: output_header = 'Starting audit...'
These two are only used once so I wouldn't make them a variable.

https://chromiumcodereview.appspot.com/110773002/diff/40001/tools/android/che...
tools/android/checkstyle/checkstyle.py:54: else:
optional: I'd remove the else, it's not necessary.

[aurimas (slooooooooow), 2013-12-10 17:12:31]

https://codereview.chromium.org/110773002/diff/40001/tools/android/checkstyle...
File tools/android/checkstyle/checkstyle.py (right):

https://codereview.chromium.org/110773002/diff/40001/tools/android/checkstyle...
tools/android/checkstyle/checkstyle.py:5: """ Script that is used by
PRESUBMIT.py to run style checks on Java files."""
On 2013/12/10 13:26:51, M-A Ruel wrote:
> ""Script

Done.

https://codereview.chromium.org/110773002/diff/40001/tools/android/checkstyle...
tools/android/checkstyle/checkstyle.py:7: 
On 2013/12/10 13:26:51, M-A Ruel wrote:
> remove one empty line

Done.

https://codereview.chromium.org/110773002/diff/40001/tools/android/checkstyle...
tools/android/checkstyle/checkstyle.py:20: if
os.path.splitext(x.LocalPath())[1].lower() == '.java']
On 2013/12/10 13:26:51, M-A Ruel wrote:
> are .JAVA files valid?

Done.

https://codereview.chromium.org/110773002/diff/40001/tools/android/checkstyle...
tools/android/checkstyle/checkstyle.py:42: output_header = 'Starting audit...'
On 2013/12/10 13:26:51, M-A Ruel wrote:
> These two are only used once so I wouldn't make them a variable.

Done.

https://codereview.chromium.org/110773002/diff/40001/tools/android/checkstyle...
tools/android/checkstyle/checkstyle.py:54: else:
On 2013/12/10 13:26:51, M-A Ruel wrote:
> optional: I'd remove the else, it's not necessary.

Done.

[commit-bot: I haz the power, 2013-12-10 17:14:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/110773002/60001

[commit-bot: I haz the power, 2013-12-10 19:33:52]

Change committed as 239824