Enable compositor tests on android.

Enable compositor tests on android.


BUG=154524
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161976

[nilesh, 2012-10-08 02:48:50]

https://codereview.chromium.org/11077011/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

https://codereview.chromium.org/11077011/diff/1/build/android/run_tests.py#ne...
build/android/run_tests.py:75: 'cc_unittests',
Lets not start running these tests directly on the main waterfall.
Can we just add the compile target first and then run them on the fyi bot for
some time?

[epenner, 2012-10-08 19:40:19]

https://codereview.chromium.org/11077011/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

https://codereview.chromium.org/11077011/diff/1/build/android/run_tests.py#ne...
build/android/run_tests.py:75: 'cc_unittests',
On 2012/10/08 02:48:50, nileshagrawal1 wrote:
> Lets not start running these tests directly on the main waterfall.
> Can we just add the compile target first and then run them on the fyi bot for
> some time?

Is removing this line sufficient? Or is there another list where I need to add
it in order to run on the FYI bots?

[nilesh, 2012-10-08 22:21:43]

On 2012/10/08 19:40:19, epenner wrote:
> https://codereview.chromium.org/11077011/diff/1/build/android/run_tests.py
> File build/android/run_tests.py (right):
> 
>
https://codereview.chromium.org/11077011/diff/1/build/android/run_tests.py#ne...
> build/android/run_tests.py:75: 'cc_unittests',
> On 2012/10/08 02:48:50, nileshagrawal1 wrote:
> > Lets not start running these tests directly on the main waterfall.
> > Can we just add the compile target first and then run them on the fyi bot
for
> > some time?
> 
> Is removing this line sufficient? Or is there another list where I need to add
> it in order to run on the FYI bots?

Yes removing that line is sufficient. Running on the FYI bot is unfortunately
more work. This is the first time we are adding a unittest bundle to the main
waterfall.
1. Add a method in build/android/buildbot/buildbot_functions.sh 
function bb_run_unit_tests_experimental {
  build/android/run_tests.py --xvfb --verbose -s cc_unittests
}
2. Call this method from build/android/buildbot/bb_fyi_tester.sh
3. Try your CL on android_fyi_dbg

[nilesh, 2012-10-09 17:06:53]

Another CL trying to do the same thing: http://codereview.chromium.org/11027067/

http://codereview.chromium.org/11077011/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

http://codereview.chromium.org/11077011/diff/1/build/android/run_tests.py#new...
build/android/run_tests.py:75: 'cc_unittests',
You can remove this line and we can add the fyi bot changes in a separate CL.

[epenner, 2012-10-10 03:42:56]

ptal

[nilesh, 2012-10-10 04:44:55]

LGTM

[commit-bot: I haz the power, 2012-10-10 16:41:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/11077011/4001

[commit-bot: I haz the power, 2012-10-10 16:41:31]

Presubmit check for 11077011-4001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    cc

Presubmit checks took 1.2s to calculate.

[epenner, 2012-10-10 16:43:47]

We need CC owner. James?

[jamesr, 2012-10-10 17:19:22]

lgtm

[commit-bot: I haz the power, 2012-10-10 17:23:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/11077011/4001

[commit-bot: I haz the power, 2012-10-13 01:09:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/11077011/4001

[commit-bot: I haz the power, 2012-10-13 01:10:00]

Failed to apply patch for cc/CCRendererSoftwareTest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/CCRendererSoftwareTest.cpp
  Hunk #1 FAILED at 91.
  1 out of 1 hunk FAILED -- saving rejects to file
cc/CCRendererSoftwareTest.cpp.rej

Patch:       cc/CCRendererSoftwareTest.cpp
Index: cc/CCRendererSoftwareTest.cpp
diff --git a/cc/CCRendererSoftwareTest.cpp b/cc/CCRendererSoftwareTest.cpp
index
95440e64e94af7d5df931991f43c85ca7ef21a2e..96365fa6b955a9ca14c7bca01b34ebe05c630444
100644
--- a/cc/CCRendererSoftwareTest.cpp
+++ b/cc/CCRendererSoftwareTest.cpp
@@ -91,10 +91,16 @@ TEST_F(CCRendererSoftwareTest, solidColorQuad)
     OwnArrayPtr<SkColor> pixels = adoptArrayPtr(new
SkColor[deviceViewportSize().width() * deviceViewportSize().height()]);
     renderer()->getFramebufferPixels(pixels.get(), outerRect);
 
+// FIXME: This fails on Android. Endianness maybe?
+// Yellow: expects 0xFFFFFF00, was 0xFF00FFFF on android.
+// Cyan:   expects 0xFF00FFFF, was 0xFFFFFF00 on android.
+// http://crbug.com/154528
+#ifndef OS_ANDROID
     EXPECT_EQ(SK_ColorYELLOW, pixels[0]);
     EXPECT_EQ(SK_ColorYELLOW, pixels[outerPixels - 1]);
     EXPECT_EQ(SK_ColorCYAN, pixels[outerSize.width() + 1]);
     EXPECT_EQ(SK_ColorCYAN, pixels[outerPixels - outerSize.width() - 2]);
+#endif
 }
 
 TEST_F(CCRendererSoftwareTest, tileQuad)

[commit-bot: I haz the power, 2012-10-15 19:38:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/11077011/20001

[commit-bot: I haz the power, 2012-10-15 21:38:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/11077011/20001

[commit-bot: I haz the power, 2012-10-15 22:07:16]

Change committed as 161976

[nilesh, 2012-10-15 22:16:43]

I am creating a patch to put this on the FYI bots.

[epenner, 2012-10-15 22:31:49]

On 2012/10/15 22:16:43, nileshagrawal1 wrote:
> I am creating a patch to put this on the FYI bots.

Awesome! Sorry for the delay in the landing. It got stuck on random failures and
then needed a rebase.