cc: Remove LayerTextureUpdater::Texture::updateRect() callback.

cc/CCResourceProvider.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CCResourceProvider_h
 #define CCResourceProvider_h
 
 #include "base/basictypes.h"
 #include "CCGraphicsContext.h"
 #include "GraphicsContext3D.h"
@@ skipping 77 matching lines @@
     ResourceId createGLTexture(int pool, const IntSize&, GC3Denum format, TextureUsageHint);
     ResourceId createBitmap(int pool, const IntSize&);
     // Wraps an external texture into a GL resource.
     ResourceId createResourceFromExternalTexture(unsigned textureId);
 
     void deleteResource(ResourceId);
 
     // Deletes all resources owned by a given pool.
     void deleteOwnedResources(int pool);
 
-    // Upload data from image, copying sourceRect (in image) into destRect (in the resource).
+    // Upload data from image, copying sourceRect (in image) to destOffset (in the resource).
     void upload(ResourceId, const uint8_t* image, const IntRect& imageRect, const IntRect& sourceRect, const IntSize& destOffset);
 
+    // Playback contents from picture, painting sourceRect (in picture) to destOffset (in the resource).
+    void acceleratedUpdate(ResourceId, SkPicture*, const IntRect& pictureRect, const IntRect& sourceRect, const IntSize& destOffset);

[piman, 2012/10/08 18:33:42]

This feels a bit out of place. I'd rather have this sit in a separate
function/class, outside of CCResourceProvider if possible. I would like to keep
CCResourceProvider as simple as possible, and not know anything about painting,
or the magic shared contexts for example.

[reveman, 2012/10/08 19:45:02]

Ok, maybe it belongs in CCTextureUpdateController. Whether we can use
accelerated painting or not depends on the resource type so we'll need some
minimal CCResourceProvider interface to handle accelerated painting properly.

+
     // Flush all context operations, kicking uploads and ensuring ordering with
     // respect to other contexts.
     void flush();
 
     // Only flush the command buffer if supported.
     // Returns true if the shallow flush occurred, false otherwise.
     bool shallowFlushIfSupported();
 
     // Creates accounting for a child, and associate it with a pool. Resources
     // transfered from that child will go to that pool. Returns a child ID.
@@ skipping 160 matching lines @@
     OwnPtr<TextureUploader> m_textureUploader;
     OwnPtr<AcceleratedTextureCopier> m_textureCopier;
     int m_maxTextureSize;
 
     DISALLOW_COPY_AND_ASSIGN(CCResourceProvider);
 };
 
 }
 
 #endif