[NaCl SDK] Generate NOTICE file automatically.

[NaCl SDK] Generate NOTICE file automatically.

BUG=149754
TBR=noelallen@chromium.org
R=sbc@chromium.org
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160711

[Sam Clegg, 2012-10-06 01:05:59]

lgtm

Although we might want to revisit/discuss how we bundle
all the licenses for the SDK components.  Might make
sense to include them all in the top level LICENSE?
And if we include them verbatim in a top level file
like this we might not want to ship duplicates in
LICENSE files spread around the tree.

http://codereview.chromium.org/11074004/diff/1/native_client_sdk/src/build_to...
File native_client_sdk/src/build_tools/build_sdk.py (right):

http://codereview.chromium.org/11074004/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:732: generate_notice.main(args)
Seems a little strange to me to construct command line
args and call another script's main() function.. but that
could just be me.

I'd sooner see a generate() function in generate_notice
that takes root=, filename= etc as args, then main() and
this function can both call that.

http://codereview.chromium.org/11074004/diff/1/native_client_sdk/src/build_to...
File native_client_sdk/src/build_tools/generate_notice.py (right):

http://codereview.chromium.org/11074004/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/generate_notice.py:34: license_text =
open(filename, 'r').read()
super minor: 'r' is the default so can be omitted.

[binji, 2012-10-08 17:51:48]

http://codereview.chromium.org/11074004/diff/1/native_client_sdk/src/build_to...
File native_client_sdk/src/build_tools/build_sdk.py (right):

http://codereview.chromium.org/11074004/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:732: generate_notice.main(args)
On 2012/10/06 01:05:59, Sam Clegg wrote:
> Seems a little strange to me to construct command line
> args and call another script's main() function.. but that
> could just be me.
> 
> I'd sooner see a generate() function in generate_notice
> that takes root=, filename= etc as args, then main() and
> this function can both call that.

Done.

http://codereview.chromium.org/11074004/diff/1/native_client_sdk/src/build_to...
File native_client_sdk/src/build_tools/generate_notice.py (right):

http://codereview.chromium.org/11074004/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/generate_notice.py:34: license_text =
open(filename, 'r').read()
On 2012/10/06 01:05:59, Sam Clegg wrote:
> super minor: 'r' is the default so can be omitted.

Done.

[commit-bot: I haz the power, 2012-10-08 21:43:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/11074004/4001

[commit-bot: I haz the power, 2012-10-08 21:43:27]

Change committed as 160711