Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issue 11071011: Address review feedback for r160338 (Closed)

Created:
8 years, 2 months ago by Nico
Modified:
8 years, 2 months ago
CC:
chromium-reviews, finnur+watch_chromium.org, darin-cc_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Address review feedback for r160338 On Windows, use Segoe UI Symbol as emoji font. On CrOS, use Droid Emoji. Simplify the defaults, they're overridden anyway. BUG=62435 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/app/resources/locale_settings_cros.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/locale_settings_win.grd View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
jshin: Is "Segoe UI Symbol" a vista+ font? Should I list a fallback for xp?
8 years, 2 months ago (2012-10-07 14:36:39 UTC) #1
tony
LGTM, but maybe wait to hear from Jungshik. I suspect there's no emoji font installed ...
8 years, 2 months ago (2012-10-08 17:04:50 UTC) #2
Nico
jshin: ping
8 years, 2 months ago (2012-10-11 13:42:34 UTC) #3
Nico
It looks like jshin is out until thursday. I'll land this, and if he has ...
8 years, 2 months ago (2012-10-15 23:50:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11071011/1
8 years, 2 months ago (2012-10-15 23:50:28 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 02:11:49 UTC) #6
Change committed as 162045

Powered by Google App Engine
This is Rietveld 408576698