Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Issue 1106993002: Roll DEPS to class-dump 3.5 (Closed)

Created:
5 years, 7 months ago by lliabraa
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll DEPS to class-dump 3.5 Removes some build warnings. Moves the class-dump repo to a github auto-mirror instead of a mirror that needs to be manually updated. This also requires that the class-dump.gyp file move from the third-party repo into the main source tree. Note that the file structure of the class-dump source changed so the .gyp had to be updated. For comparison, the old .class-dump.gyp can be found at https://chromium.googlesource.com/chromium/deps/class-dump/+/master/class-dump.gyp BUG=318160 Committed: https://crrev.com/1c80791ce7c29a29fc816d89d1a5fa2ac6503b3e Cr-Commit-Position: refs/heads/master@{#330798}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix copyright #

Total comments: 2

Patch Set 3 : moved checkout to testing/iossim/third_party/class-dump/src #

Patch Set 4 : revert to patchset1 due to gclient limitations #

Patch Set 5 : ignore some warnings in the xcodebuild #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -2 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A testing/iossim/class-dump.gyp View 1 2 3 4 1 chunk +204 lines, -0 lines 0 comments Download
M testing/iossim/iossim.gyp View 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (13 generated)
lliabraa
5 years, 7 months ago (2015-04-27 13:05:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106993002/1
5 years, 7 months ago (2015-04-27 13:10:21 UTC) #4
justincohen
In description: s/to ta github/to the github LGTM with nits. https://codereview.chromium.org/1106993002/diff/1/testing/iossim/class-dump.gyp File testing/iossim/class-dump.gyp (right): https://codereview.chromium.org/1106993002/diff/1/testing/iossim/class-dump.gyp#newcode1 ...
5 years, 7 months ago (2015-04-27 13:56:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106993002/20001
5 years, 7 months ago (2015-04-27 13:58:50 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-04-27 13:58:52 UTC) #10
lliabraa
+rohitrao for OWNERS
5 years, 7 months ago (2015-04-27 14:02:26 UTC) #12
rohitrao (ping after 24h)
LGTM The more standard pattern would be to put the DEPS repo into a iossim/third_party/class-dump/src ...
5 years, 7 months ago (2015-04-27 14:11:14 UTC) #13
rohitrao (ping after 24h)
https://codereview.chromium.org/1106993002/diff/20001/testing/iossim/iossim.gyp File testing/iossim/iossim.gyp (left): https://codereview.chromium.org/1106993002/diff/20001/testing/iossim/iossim.gyp#oldcode86 testing/iossim/iossim.gyp:86: 'third_party/class-dump/class-dump.gyp:class-dump#host', On 2015/04/27 14:11:14, rohitrao wrote: > Should we ...
5 years, 7 months ago (2015-04-27 14:11:51 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106993002/40001
5 years, 7 months ago (2015-04-27 14:47:44 UTC) #17
lliabraa
PTAL - I moved the checkout location based on Rohit's feedback and included the README.chromium ...
5 years, 7 months ago (2015-04-27 14:49:37 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/61260)
5 years, 7 months ago (2015-04-27 14:51:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106993002/60001
5 years, 7 months ago (2015-05-20 18:42:18 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-20 20:54:48 UTC) #26
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/1c80791ce7c29a29fc816d89d1a5fa2ac6503b3e Cr-Commit-Position: refs/heads/master@{#330798}
5 years, 7 months ago (2015-05-20 20:55:36 UTC) #27
sgurun-gerrit only
5 years, 7 months ago (2015-05-20 21:16:20 UTC) #28
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1147163003/ by sgurun@chromium.org.

The reason for reverting is: Breaking
https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/7076

.

Powered by Google App Engine
This is Rietveld 408576698