Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2869)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 11068027: OnDownloadStarted takes DownloadItem* instead of DownloadId (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: @r160830 Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 2e21ccabf9e5981bebaef8a1920ecb220660c3ac..eb18822cf04f497497626e513326a484444c5062 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -645,12 +645,15 @@ bool DownloadsDownloadFunction::RunImpl() {
return true;
}
-void DownloadsDownloadFunction::OnStarted(DownloadId dl_id, net::Error error) {
+void DownloadsDownloadFunction::OnStarted(
+ DownloadItem* item, net::Error error) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- VLOG(1) << __FUNCTION__ << " " << dl_id << " " << error;
- if (dl_id.local() >= 0) {
- SetResult(base::Value::CreateIntegerValue(dl_id.local()));
+ VLOG(1) << __FUNCTION__ << " " << item << " " << error;
+ if (item) {
+ DCHECK_EQ(net::OK, error);
+ SetResult(base::Value::CreateIntegerValue(item->GetId()));
} else {
+ DCHECK_NE(net::OK, error);
error_ = net::ErrorToString(error);
}
SendResponse(error_.empty());
« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.h ('k') | chrome/browser/extensions/extension_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698