Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 11066124: Added media.gyp dependency into content/content_test.gypi. (Closed)

Created:
8 years, 2 months ago by youngki
Modified:
8 years, 2 months ago
Reviewers:
Avi (use Gerrit), piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, bryeung
Visibility:
Public.

Description

Added media.gyp dependency into content/content_test.gypi. content/public/test/content_test_suite_base.cc includes media/base/media.h but its gyp file is missing media.gyp dependency. This is a spin-off CL from 11075006. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
youngki
8 years, 2 months ago (2012-10-11 17:27:47 UTC) #1
piman
lgtm
8 years, 2 months ago (2012-10-12 16:54:47 UTC) #2
Avi (use Gerrit)
ouch. lgtm
8 years, 2 months ago (2012-10-12 16:56:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/youngki@chromium.org/11066124/1
8 years, 2 months ago (2012-10-14 03:49:50 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-14 05:52:33 UTC) #5
Change committed as 161800

Powered by Google App Engine
This is Rietveld 408576698