Show custom wallpaper container and cannot access wallpaper message when device offline.

Show custom wallpaper container and cannot access wallpaper message when device offline.

When no network, xmlhttprequest will throw an exception 101. This CL catches the exception and shows an error message in wallpaper picker.


BUG=153895
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162174

[bshe, 2012-10-09 23:06:16]

Hey Rob.

Could you please take a look at this CL? It catches an exception throwed by
XMLHttpRequeset when network is not available.

After this CL, wallpaper picker should display an error message and show custom
wallpaper picker in the UI instead of an empty page.

Thanks!

[bshe, 2012-10-15 14:35:58]

Friendly ping in case it is buried.

On 2012/10/09 23:06:16, bshe wrote:
> Hey Rob.
> 
> Could you please take a look at this CL? It catches an exception throwed by
> XMLHttpRequeset when network is not available.
> 
> After this CL, wallpaper picker should display an error message and show
custom
> wallpaper picker in the UI instead of an empty page.
> 
> Thanks!

[flackr, 2012-10-16 15:29:48]

Hey, sorry for the delay. The actual change looks good, however I don't like how
we have to duplicate the entire outer block logic for fetching the fallback and
would rather see this as a list of manifests to try.

https://codereview.chromium.org/11066090/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
(right):

https://codereview.chromium.org/11066090/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js:98:
this.parseManifest_(xhr.responseText);
This nested structure which does the same thing to fallback duplicates all of
the logic. Can you make this use a list and try the first item, then fallback to
the next, etc.

[bshe, 2012-10-16 16:01:48]

Good suggestion. Could you take another look? Thanks!

https://codereview.chromium.org/11066090/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
(right):

https://codereview.chromium.org/11066090/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js:98:
this.parseManifest_(xhr.responseText);
Done.

On 2012/10/16 15:29:48, flackr wrote:
> This nested structure which does the same thing to fallback duplicates all of
> the logic. Can you make this use a list and try the first item, then fallback
to
> the next, etc.

[flackr, 2012-10-16 16:08:23]

lgtm

[commit-bot: I haz the power, 2012-10-16 16:14:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/11066090/8001

[commit-bot: I haz the power, 2012-10-16 18:13:56]

Change committed as 162174