Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
11066080:
Initial version of Dart web components article (Closed)
|
Created:
8 years, 2 months ago by Siggi Cherem (dart-lang) Modified:
8 years, 2 months ago CC:
reviews_dartlang.org Base URL:
git@github.com:sigmundch/dartlang.org.git@master Visibility:
Public. |
DescriptionInitial version of Dart web components article.
Committed: https://github.com/dart-lang/dartlang.org/commit/05d7d4b
Patch Set 1 #Patch Set 2 : moved generated code elsewhere #
Total comments: 33
Patch Set 3 : roudn1 of comments #
Total comments: 30
Patch Set 4 : #Patch Set 5 : #
Total comments: 14
Patch Set 6 : john's comments #
Total comments: 58
Patch Set 7 : #Patch Set 8 : remove css changes for now #
Messages
Total messages: 11 (0 generated)
Here's a start, Siggi. A lot of my focus was on removing extra words and making wording consistent, to help people read this more easily. (It's great stuff! I especially love how you built in examples.) More later... https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... File src/site/articles/dart-web-components/index.markdown (right): https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:11: _Written by ...<br /> update the next 3 lines (of course) https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:15: ## Dart web components Delete this line (already covered by page.title, above) https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:45: [Dart web components][dwc] are a combination of templating, data-binding, and GLOBAL: data-binding -> data binding (If you were using it as an adjective phrase, as in "data-binding framework", then the hyphen would be good. But it looks wrong here, on its own.) https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:45: [Dart web components][dwc] are a combination of templating, data-binding, and Are web components really techniques? I think of them as building blocks, not mere behavior. Also, it seemed weird to have the first words in the article be a link to an unknown site. How about something like: Dart web components provide templating, data binding, and encapsulation, to help you write web applications at scale. An early version is in the [dart-web-components project]. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:48: There are many UI frameworks in the web intended for writing web applications in "There are..." is a vague way to start (those 2 words have no real meaning). Strengthen it using words with meaning, such as: Many UI frameworks exist for writing web apps in JavaScript—for example, ... Also: - GLOBAL: JS -> JavaScript - change the ',' after JavaScript to be a — (em-dash), for emphasis/variety https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:51: of these frameworks directly into browser platform. A result of that has been into -> into the A result of that -> A result https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:52: added features like Shadow Dom and [Web Components][wc], and other experimental No link to Shadow DOM? We should standardize on the words and capitalization for these 3 features. Maybe: the Shadow DOM Web Components Model-Driven Views (MDV) [use only MDV afterward in this page] I'd be just as happy with "the shadow DOM, web components, and model-driven views (MDV)." Consistency within this doc set is what matters to me. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:55: Dart web components have a similar role in Dart. They are the result of Could be shorter/clearer. How about. Dart web components combine the ideas of Web Components and MDV, adapting them to work well with Dart. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:57: adapting them to include Dart in the picture. The dart web component tools will I was confused by "dart web component tools". We usually use "tools" to mean "command-line tools". Also, by "will" -- is this not implemented yet? Maybe: Dart web components take advantage of advanced browser features when possible, emulating missing features when necessary. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:66: ## MDV Templates in Dart Templates -> templates (we use Title Caps for page titles but Sentence caps for headings) https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:69: succint declarative syntax. Dart web components follow closely follow closely -> closely follow https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:69: succint declarative syntax. Dart web components follow closely succint -> succinct follow closely -> closely follow https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:70: the syntax of [Model Driven Views][mdv] (MDV), which is basically the syntax of ... MDV -> the MDV syntax https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:73: * **one-way data-binding**: how to embed data into your UI; We usually capitalize the first words in a list. Also, the "how to" adds some extra heft, and we don't punctuate lists like this (except perhaps to add periods after everything). How about: **One-way data binding:** Embed data in your UI **Two-way data binding:** Keep data in sync with UI changes **Event listeners:** React to UI events **Conditionals:** Selectively show parts of the UI **Loops:** Construct lists and tables by iterating over collections https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:83: ### Data-bindings Should this be "One-way data binding"? https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:85: You can inject data in your template by simply using `{{'{{'}} expresions }}`. "by simply using" -> "using" expresions -> expressions (can it really be multiple expressions?)
Thanks Kathy! this is really useful. I uploaded a new version addressing what you mentioned so far. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... File src/site/articles/dart-web-components/index.markdown (right): https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:11: _Written by ...<br /> On 2012/10/09 23:16:57, Kathy Walrath wrote: > update the next 3 lines (of course) Done. thanks :) - I looked at the other articles, and they all seems to be individually authored. Is it discouraged to say "written by the dart-team" ? https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:15: ## Dart web components On 2012/10/09 23:16:57, Kathy Walrath wrote: > Delete this line > > (already covered by page.title, above) Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:45: [Dart web components][dwc] are a combination of templating, data-binding, and On 2012/10/09 23:16:57, Kathy Walrath wrote: > > GLOBAL: data-binding -> data binding > > (If you were using it as an adjective phrase, as in "data-binding framework", > then the hyphen would be good. But it looks wrong here, on its own.) Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:45: [Dart web components][dwc] are a combination of templating, data-binding, and On 2012/10/09 23:16:57, Kathy Walrath wrote: > Are web components really techniques? I think of them as building blocks, not > mere behavior. Also, it seemed weird to have the first words in the article be a > link to an unknown site. How about something like: > > Dart web components provide templating, data binding, and encapsulation, to help > you write web applications at scale. > An early version is in the [dart-web-components project]. nice, thanks. Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:48: There are many UI frameworks in the web intended for writing web applications in On 2012/10/09 23:16:57, Kathy Walrath wrote: > "There are..." is a vague way to start (those 2 words have no real meaning). > Strengthen it using words with meaning, such as: > > Many UI frameworks exist for writing web apps in JavaScript—for example, ... > > Also: > - GLOBAL: JS -> JavaScript > - change the ',' after JavaScript to be a — (em-dash), for emphasis/variety Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:51: of these frameworks directly into browser platform. A result of that has been On 2012/10/09 23:16:57, Kathy Walrath wrote: > into -> into the > A result of that -> A result Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:52: added features like Shadow Dom and [Web Components][wc], and other experimental On 2012/10/09 23:16:57, Kathy Walrath wrote: > No link to Shadow DOM? > > We should standardize on the words and capitalization for these 3 features. > Maybe: > > the Shadow DOM > Web Components > Model-Driven Views (MDV) [use only MDV afterward in this page] > > I'd be just as happy with "the shadow DOM, web components, and model-driven > views (MDV)." Consistency within this doc set is what matters to me. Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:55: Dart web components have a similar role in Dart. They are the result of On 2012/10/09 23:16:57, Kathy Walrath wrote: > Could be shorter/clearer. How about. > > Dart web components combine the ideas of Web Components and MDV, adapting them > to work well with Dart. Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:57: adapting them to include Dart in the picture. The dart web component tools will On 2012/10/09 23:16:57, Kathy Walrath wrote: > I was confused by "dart web component tools". We usually use "tools" to mean > "command-line tools". Also, by "will" -- is this not implemented yet? Maybe: > > Dart web components take advantage of advanced browser features when possible, > emulating missing features when necessary. good points... fixed. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:66: ## MDV Templates in Dart On 2012/10/09 23:16:57, Kathy Walrath wrote: > Templates -> templates > > (we use Title Caps for page titles but Sentence caps for headings) Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:69: succint declarative syntax. Dart web components follow closely On 2012/10/09 23:16:57, Kathy Walrath wrote: > succint -> succinct > follow closely -> closely follow Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:69: succint declarative syntax. Dart web components follow closely On 2012/10/09 23:16:57, Kathy Walrath wrote: > follow closely -> closely follow Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:70: the syntax of [Model Driven Views][mdv] (MDV), which is basically On 2012/10/09 23:16:57, Kathy Walrath wrote: > the syntax of ... MDV -> the MDV syntax Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:73: * **one-way data-binding**: how to embed data into your UI; On 2012/10/09 23:16:57, Kathy Walrath wrote: > We usually capitalize the first words in a list. Also, the "how to" adds some > extra heft, and we don't punctuate lists like this (except perhaps to add > periods after everything). How about: > > **One-way data binding:** Embed data in your UI > **Two-way data binding:** Keep data in sync with UI changes > **Event listeners:** React to UI events > **Conditionals:** Selectively show parts of the UI > **Loops:** Construct lists and tables by iterating over collections Done. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:83: ### Data-bindings On 2012/10/09 23:16:57, Kathy Walrath wrote: > Should this be "One-way data binding"? yes :) thanks https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:85: You can inject data in your template by simply using `{{'{{'}} expresions }}`. On 2012/10/09 23:16:57, Kathy Walrath wrote: > "by simply using" -> "using" > > expresions -> > expressions > > (can it really be multiple expressions?) good point, no it should be singular
This is a great write up! I really enjoy how this builds up the story piece by piece. https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... File src/site/articles/dart-web-components/index.markdown (right): https://chromiumcodereview.appspot.com/11066080/diff/6006/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:52: added features like Shadow Dom and [Web Components][wc], and other experimental On 2012/10/09 23:51:08, sigmund wrote: > On 2012/10/09 23:16:57, Kathy Walrath wrote: > > No link to Shadow DOM? > > > > We should standardize on the words and capitalization for these 3 features. > > Maybe: > > > > the Shadow DOM > > Web Components > > Model-Driven Views (MDV) [use only MDV afterward in this page] > > > > I'd be just as happy with "the shadow DOM, web components, and model-driven > > views (MDV)." Consistency within this doc set is what matters to me. > > Done. Could you add a link to Shadow DOM? http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... File src/site/articles/dart-web-components/index.markdown (right): https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:82: example below shows a simple hello world program where the value of the dart uppercase Dart? https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:101: {% sample 300px 200px http://dart-lang.github.com/dart-web-components/example/explainer/helloworld.... %} meta: include links to the sample code in source control? If I was a user I'd be wanting to see under the hood :), in other words, get my hands on the raw files. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:109: Dart web components do this by using the `watchers.dart` library (included with Should this link to the apidoc for watchers? (I realize we don't have apidocs up yet, but ... :) ) https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:137: The code manually invokes `watchers.dispatch()` to make a change visible to the likewise would be cool to link to API docs https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:178: We want to make Dart web components have, to a great extend, feature and design typo: "extent" instead of "extend" https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:180: template language where it is appropriate. MDV restricts data-binding remove "where it is appropriate" https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:183: valid Dart and valid JavaScript as well. That also means that advanced Dart expressions not sure we are trying to stay under 80 col? this line is a tad over https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:189: [specification document (link TBR)][]. This renders showing the link. Did you mean to do something else with it? I think it would be fine to just say: "A full specification of the expression syntax will be available soon." https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:307: model-view-viewmodel architecture. One-way databindings, two-way databindings, "databinding" with a space? "data binding" https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:353: The `<element>` tag basically declares a component whose view is defined perhaps remove "basically"? "visual appearance" might be more clear than "view" "declared" instead of "defined"? https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:357: Components can be thought as if they are extending DOM nodes, their declaration "HTML elements" instead of "DOM nodes"? https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:422: Web components allows us to do import other components using `<link typo: "to import" instead of "to do import" https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:424: `clickcounter.html` that contains the declaration of the click-counter component wondering if we should name the component "x-click-counter" instead of "x-counter" since we refer to it that way? https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:504: You can also follow the project in [github][dwc], track and file bugs in our think this should be "GitHub" to match how they write their name https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:506: of [todomvc][todomvcindwc]. likewise, I think this should be "TodoMVC" to match the style of name they use: http://addyosmani.github.com/todomvc/
thanks! addressed most of your comments except for the references to API docs - I'll look tomorrow into adding those. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... File src/site/articles/dart-web-components/index.markdown (right): https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:82: example below shows a simple hello world program where the value of the dart On 2012/10/10 01:18:29, John Messerly wrote: > uppercase Dart? Done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:101: {% sample 300px 200px http://dart-lang.github.com/dart-web-components/example/explainer/helloworld.... %} On 2012/10/10 01:18:29, John Messerly wrote: > meta: include links to the sample code in source control? > > If I was a user I'd be wanting to see under the hood :), in other words, get my > hands on the raw files. cool. done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:109: Dart web components do this by using the `watchers.dart` library (included with On 2012/10/10 01:18:29, John Messerly wrote: > Should this link to the apidoc for watchers? > (I realize we don't have apidocs up yet, but ... :) ) good point. I made it a link to the source code for now, but we should publish the API docs and update it here. I'll take a look into it. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:137: The code manually invokes `watchers.dispatch()` to make a change visible to the On 2012/10/10 01:18:29, John Messerly wrote: > likewise would be cool to link to API docs cool idea. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:178: We want to make Dart web components have, to a great extend, feature and design On 2012/10/10 01:18:29, John Messerly wrote: > typo: "extent" instead of "extend" :), thx https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:180: template language where it is appropriate. MDV restricts data-binding On 2012/10/10 01:18:29, John Messerly wrote: > remove "where it is appropriate" Done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:183: valid Dart and valid JavaScript as well. That also means that advanced Dart expressions On 2012/10/10 01:18:29, John Messerly wrote: > not sure we are trying to stay under 80 col? this line is a tad over thx, done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:189: [specification document (link TBR)][]. On 2012/10/10 01:18:29, John Messerly wrote: > This renders showing the link. Did you mean to do something else with it? I > think it would be fine to just say: "A full specification of the expression > syntax will be available soon." Done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:307: model-view-viewmodel architecture. One-way databindings, two-way databindings, On 2012/10/10 01:18:29, John Messerly wrote: > "databinding" with a space? > "data binding" Done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:353: The `<element>` tag basically declares a component whose view is defined On 2012/10/10 01:18:29, John Messerly wrote: > perhaps remove "basically"? > "visual appearance" might be more clear than "view" > "declared" instead of "defined"? Done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:357: Components can be thought as if they are extending DOM nodes, their declaration On 2012/10/10 01:18:29, John Messerly wrote: > "HTML elements" instead of "DOM nodes"? Done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:422: Web components allows us to do import other components using `<link On 2012/10/10 01:18:29, John Messerly wrote: > typo: "to import" instead of "to do import" Done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:424: `clickcounter.html` that contains the declaration of the click-counter component On 2012/10/10 01:18:29, John Messerly wrote: > wondering if we should name the component "x-click-counter" instead of > "x-counter" since we refer to it that way? Done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:504: You can also follow the project in [github][dwc], track and file bugs in our On 2012/10/10 01:18:29, John Messerly wrote: > think this should be "GitHub" to match how they write their name Done. https://chromiumcodereview.appspot.com/11066080/diff/3002/src/site/articles/d... src/site/articles/dart-web-components/index.markdown:506: of [todomvc][todomvcindwc]. On 2012/10/10 01:18:29, John Messerly wrote: > likewise, I think this should be "TodoMVC" to match the style of name they use: > http://addyosmani.github.com/todomvc/ Done.
just added links to api docs...
https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... File src/site/_plugins/code_sample.rb (right): https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... src/site/_plugins/code_sample.rb:1: copyright header? (p.s. sorry I forgot to review this file the first time!) https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... src/site/_plugins/code_sample.rb:14: if @src_url != nil I think in Ruby, you'd typically write: if @src_url ... end https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... src/site/_plugins/code_sample.rb:18: ("\n\n<table sytle='border:0px'><thead>" + nit: you don't need the +, Ruby will concat adjacent string literals like Dart :) https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... src/site/_plugins/code_sample.rb:34: sample_params = params.split(' ') common to write this as: @width, @height, @url = params.split(' ') https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/articles/... File src/site/articles/dart-web-components/index.markdown (right): https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/articles/... src/site/articles/dart-web-components/index.markdown:51: like shadow DOM and [web components][wc], and other experimental and cool ideas Still need the shadow DOM link :) http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/articles/... src/site/articles/dart-web-components/index.markdown:527: [watcher]: http://dart-lang.github.com/dart-web-components/docs/watcher.html eventually, might want to create a Jekyll module for api doc links? Could happen later though.
Thanks! Thanks for the tips on the ruby code. I've never written ruby before, so all tips are useful :) https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... File src/site/_plugins/code_sample.rb (right): https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... src/site/_plugins/code_sample.rb:1: On 2012/10/10 02:37:20, John Messerly wrote: > copyright header? > > (p.s. sorry I forgot to review this file the first time!) Done. https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... src/site/_plugins/code_sample.rb:14: if @src_url != nil On 2012/10/10 02:37:20, John Messerly wrote: > I think in Ruby, you'd typically write: > > if @src_url > ... > end Done. https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... src/site/_plugins/code_sample.rb:18: ("\n\n<table sytle='border:0px'><thead>" + On 2012/10/10 02:37:20, John Messerly wrote: > nit: you don't need the +, Ruby will concat adjacent string literals like Dart > :) mmm.. this didn't work for me, the render method returns only the last segment of the string, is there something special when you add new lines in between? I thought () would do the trick, but apparently not. https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... src/site/_plugins/code_sample.rb:34: sample_params = params.split(' ') On 2012/10/10 02:37:20, John Messerly wrote: > common to write this as: > > @width, @height, @url = params.split(' ') cool. I'd really like to have this in dart... https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/articles/... File src/site/articles/dart-web-components/index.markdown (right): https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/articles/... src/site/articles/dart-web-components/index.markdown:51: like shadow DOM and [web components][wc], and other experimental and cool ideas On 2012/10/10 02:37:20, John Messerly wrote: > Still need the shadow DOM link :) > > http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html Done. Thanks for the link :) I was initially going to use the 'working draft' instead of the 'editors draft'... it's a bit confusing... https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/articles/... src/site/articles/dart-web-components/index.markdown:527: [watcher]: http://dart-lang.github.com/dart-web-components/docs/watcher.html On 2012/10/10 02:37:20, John Messerly wrote: > eventually, might want to create a Jekyll module for api doc links? Could happen > later though. yeah - not sure how general we can make them since modules are available to all articles, but each article/project probably will have their docs somewhere else. Maybe once we have docs hosted on pub?
lgtm https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... File src/site/_plugins/code_sample.rb (right): https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/_plugins/... src/site/_plugins/code_sample.rb:18: ("\n\n<table sytle='border:0px'><thead>" + On 2012/10/10 17:20:55, sigmund wrote: > On 2012/10/10 02:37:20, John Messerly wrote: > > nit: you don't need the +, Ruby will concat adjacent string literals like Dart > > :) > > mmm.. this didn't work for me, the render method returns only the last segment > of the string, is there something special when you add new lines in between? I > thought () would do the trick, but apparently not. doh, I guess you need to escape the end of line with backslash. Nevermind then :) alternative would be to let the string continue or use a heredoc, but then you couldn't indent it nicely, it would have to be flush with the left side (or your output would get indent). https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/articles/... File src/site/articles/dart-web-components/index.markdown (right): https://chromiumcodereview.appspot.com/11066080/diff/10004/src/site/articles/... src/site/articles/dart-web-components/index.markdown:527: [watcher]: http://dart-lang.github.com/dart-web-components/docs/watcher.html On 2012/10/10 17:20:55, sigmund wrote: > On 2012/10/10 02:37:20, John Messerly wrote: > > eventually, might want to create a Jekyll module for api doc links? Could > happen > > later though. > > yeah - not sure how general we can make them since modules are available to all > articles, but each article/project probably will have their docs somewhere else. > Maybe once we have docs hosted on pub? yeah, good point. you'd need some way to set the "base url" on a per-article basis.
Here's another go at it. Some overall comments: - Printing doesn't seem to work any more. (It mostly worked in the first draft.) Did you change the table size? Even in landscape, lots of text was missing. - Because I couldn't print, I couldn't do a real copyedit. It'd be nice to do another round (I know I've missed stuff), but I don't want to hold up this article... Let me know what you want me to do. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/_plugins/... File src/site/_plugins/code_sample.rb (right): https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/_plugins/... src/site/_plugins/code_sample.rb:24: "</td><td><strong>Sample running</strong></td></tr>" + Sample running -> Running sample (or something else. what's important: make the first words of the two captions different. people scan, and they often don't notice anything but the first word.) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... File src/site/articles/dart-web-components/index.markdown (right): https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:13: Updated: October 2012_ Delete the "Updated" line https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:43: Dart web components provide a templating, data binding, and encapsulation, to a templating -> templates https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:47: Many UI frameworks exist for writing web apps in JavaScript -- for example -- -> — (no spaces around it) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:50: frameworks directly into the browser platform. A result has been added features I told you to do this, but it's too easy to read wrong. :( How about: A result ... -> As a result, browsers have added features like ..., and other experimental and cool ideas have been proposed, such as ... (MDV). https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:58: In this article, we'll walk through some examples that illustrate how to write In this article, we'll walk -> This article walks https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:59: and use Dart web components. Soon we'll be creating a document with a detailed I initially thought that "Soon" meant "In this document", in part because I wasn't sure who "we" meant.) How about: We plan to publish additional documents soon, including a detailed specification and instructions for using Dart web component tools. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:61: component tools. It could be helpful to stick a table of contents here. E.g., see: http://www.dartlang.org/articles/js-dart-interop/ There doesn't appear to be an autogeneration for TOCs, but the IDs are automatically generated from heading text. Or you can specify your own ID after a title, like this: #### Contents {#toc} Even if you don't show a TOC, it's helpful to have one during development so you can see your structure clearly. E.g., creating one for your article made me want to change the section headings/order a bit and change the "Upcoming features" from ### to ##. If you do everything I suggest, you'll have something like this: MDV templates in Dart One-way data binding Two-way data binding Conditionals Loops Event listeners Summary of templates Web components in Dart Declaring a component Instantiating a component Passing data to a component Importing a component Upcoming features Tools for using Dart web components More information https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:66: succinct declarative syntax. Dart web components closely follow the MDV syntax, delete "declarative"? (it's repetitive due to the earlier "declare") alternatively, change "declare" to "specify" https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:71: * **Events listeners**: Easily attach code that reacts to UI events Events listeners sounds weird to me. -> Event listeners ? Also, the event listener section is after the Loops section, so move this item down to the end of the list. (The reason: It's good to match order unless you have a good reason not to. It helps the reader know what to expect, and not waste time thinking. :) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:75: We made some changes to make sure that using Dart with MDV feels natural, but make sure -> ensure OR be sure (to avoid repetition of "made") https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:79: ### One-way data bindings bindings -> binding (Match the item in the list) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:146: ### Two-way data bindings bindings -> binding https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:146: ### Two-way data bindings sd https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:148: Two-way data bindings lets us define that we want a DOM element's value bindings -> binding https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:177: the text box, the string and it's length will be updated in other parts of the it's -> its (if you think of 'his' and 'hers', then 'its' for possessive should be easier to remember) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:180: ### Data-binding expressions If you look at the TOC, this isn't like the other sections. Change it to a note? I don't know how to do this in markdown, but I think you can just use HTML: <aside> <div class="alert alert-info"> <strong>A note about expressions:</strong> ...words go here... </div> </aside> https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:188: between `{{'{{'}}expressions}}`, however you can always hide complex expressions between -> within expressions}} -> expression}} globally (because there can be only one, correct?) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:226: Template loops allow us to iterate over iterable Dart collections. The following You should mention the `iterate` attribute in this description. Something like: To create a loop that operates on each item in a Dart collection, use the `iterate` attribute in a `<template>` tag. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:281: ### Listen to UI events -> ### Event listeners https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:308: ### Templating summary Templating summary -> Summary of templates (Having the "Summary" first is a visual cue. Plus you've used "template", not "templating" before, so it's good to keep that consistent.) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:312: model-view-viewmodel architecture. One-way data bindings, two-way data bindings, bindings -> binding (twice in this line; to match what we used before) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:313: and data-action listeners, help reduce the need for manually creating controller , help -> help https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:422: ### Working at scale -> ### Importing a component (to match the task orientation of previous headings in this section, plus give a bit more info) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:452: ### Upcoming features ### -> ## (since these features are for templates as well as components) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:457: * Support for sub-components. Using a special `<content>` tag, a component GLOBAL: sub-component -> subcomponent (it's in the dictionary - I looked) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:487: ## Developing and using Dart web components -> ## Tools for developing and using Dart web components OR ## Tools for Dart web components (having "Tools" first is very helpful) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:504: ## Exploring more ## Exploring more -> ## More information OR ## Resources (I wasn't sure what to expect from "Exploring more", plus it just sounded like it was missing a word or two after "more") https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:512: [issue tracker][bugs], and play with other examples in our repo, like our port like -> such as (in general, "like" is easy to misread. It has too many meanings.)
On 2012/10/11 01:01:21, Kathy Walrath wrote: > Here's another go at it. Some overall comments: > > - Printing doesn't seem to work any more. (It mostly worked in the first draft.) > Did you change the table size? Even in landscape, lots of text was missing. that's strange - the only thing I changed was that the page demanded a content width of 1170px and I changed that to 1120px because it didn't fit on my laptop screen (I had to use horizontal scrolling). I made a comment when I first uploaded the pull request that I wasn't sure about this change, but I forgot to copy that question here. Take a look: https://github.com/dart-lang/dartlang.org/pull/11#discussion_r1797029 Basically the entire .css file had a merge conflict, and I tried to manually resolve it. How do I test that this is working? The print preview here looks to have everything, but I'm probably overlooking it. > > - Because I couldn't print, I couldn't do a real copyedit. It'd be nice to do > another round (I know I've missed stuff), but I don't want to hold up this > article... Let me know what you want me to do. I'm heading out for the day, but I'll work on your comments tomorrow. I'm ok doing another round or push a version and iterate while it is live. My only constraint is having this live by Friday.
Thanks once more Kathy, you are awesome :) I made all the changes, and uploaded a new version here. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/_plugins/... File src/site/_plugins/code_sample.rb (right): https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/_plugins/... src/site/_plugins/code_sample.rb:24: "</td><td><strong>Sample running</strong></td></tr>" + On 2012/10/11 01:01:21, Kathy Walrath wrote: > Sample running -> Running sample > > (or something else. what's important: make the first words of the two captions > different. people scan, and they often don't notice anything but the first > word.) Interesting - thanks! https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... File src/site/articles/dart-web-components/index.markdown (right): https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:13: Updated: October 2012_ On 2012/10/11 01:01:21, Kathy Walrath wrote: > Delete the "Updated" line Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:43: Dart web components provide a templating, data binding, and encapsulation, to On 2012/10/11 01:01:21, Kathy Walrath wrote: > a templating -> templates Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:47: Many UI frameworks exist for writing web apps in JavaScript -- for example On 2012/10/11 01:01:21, Kathy Walrath wrote: > -- -> — > (no spaces around it) ah, thanks :) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:50: frameworks directly into the browser platform. A result has been added features On 2012/10/11 01:01:21, Kathy Walrath wrote: > I told you to do this, but it's too easy to read wrong. :( How about: > > A result ... -> > As a result, browsers have added features like ..., and other experimental and > cool ideas have been proposed, such as ... (MDV). Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:58: In this article, we'll walk through some examples that illustrate how to write On 2012/10/11 01:01:21, Kathy Walrath wrote: > In this article, we'll walk -> This article walks Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:59: and use Dart web components. Soon we'll be creating a document with a detailed On 2012/10/11 01:01:21, Kathy Walrath wrote: > I initially thought that "Soon" meant "In this document", in part because I > wasn't sure who "we" meant.) How about: > > We plan to publish additional documents soon, including a detailed specification > and instructions for using Dart web component tools. done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:61: component tools. On 2012/10/11 01:01:21, Kathy Walrath wrote: > It could be helpful to stick a table of contents here. E.g., see: > > http://www.dartlang.org/articles/js-dart-interop/ > > There doesn't appear to be an autogeneration for TOCs, but the IDs are > automatically generated from heading text. Or you can specify your own ID after > a title, like this: > > #### Contents {#toc} > > Even if you don't show a TOC, it's helpful to have one during development so you > can see your structure clearly. E.g., creating one for your article made me want > to change the section headings/order a bit and change the "Upcoming features" > from ### to ##. If you do everything I suggest, you'll have something like this: > > MDV templates in Dart > One-way data binding > Two-way data binding > Conditionals > Loops > Event listeners > Summary of templates > Web components in Dart > Declaring a component > Instantiating a component > Passing data to a component > Importing a component > Upcoming features > Tools for using Dart web components > More information Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:66: succinct declarative syntax. Dart web components closely follow the MDV syntax, On 2012/10/11 01:01:21, Kathy Walrath wrote: > delete "declarative"? (it's repetitive due to the earlier "declare") > > alternatively, change "declare" to "specify" Done. Did the latter because I wanted to emphasize that the way you specify them is in a declarative language. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:71: * **Events listeners**: Easily attach code that reacts to UI events On 2012/10/11 01:01:21, Kathy Walrath wrote: > Events listeners sounds weird to me. > -> > Event listeners > ? > > Also, the event listener section is after the Loops section, so move this item > down to the end of the list. > > (The reason: It's good to match order unless you have a good reason not to. It > helps the reader know what to expect, and not waste time thinking. :) Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:75: We made some changes to make sure that using Dart with MDV feels natural, but On 2012/10/11 01:01:21, Kathy Walrath wrote: > make sure -> ensure > OR be sure > > (to avoid repetition of "made") Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:79: ### One-way data bindings On 2012/10/11 01:01:21, Kathy Walrath wrote: > bindings -> binding > > (Match the item in the list) Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:146: ### Two-way data bindings On 2012/10/11 01:01:21, Kathy Walrath wrote: > bindings -> binding Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:148: Two-way data bindings lets us define that we want a DOM element's value On 2012/10/11 01:01:21, Kathy Walrath wrote: > bindings -> binding Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:177: the text box, the string and it's length will be updated in other parts of the On 2012/10/11 01:01:21, Kathy Walrath wrote: > it's -> its > > (if you think of 'his' and 'hers', then 'its' for possessive should be easier to > remember) thanks :) - this is one where if I think about it I can see it, but I easily read through it without noticing it :( https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:180: ### Data-binding expressions On 2012/10/11 01:01:21, Kathy Walrath wrote: > If you look at the TOC, this isn't like the other sections. Change it to a note? > I don't know how to do this in markdown, but I think you can just use HTML: > > <aside> > <div class="alert alert-info"> > <strong>A note about expressions:</strong> > ...words go here... > </div> > </aside> > Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:188: between `{{'{{'}}expressions}}`, however you can always hide complex expressions On 2012/10/11 01:01:21, Kathy Walrath wrote: > between -> within > > expressions}} -> expression}} > globally > (because there can be only one, correct?) correct - thank you :) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:226: Template loops allow us to iterate over iterable Dart collections. The following On 2012/10/11 01:01:21, Kathy Walrath wrote: > You should mention the `iterate` attribute in this description. Something like: > > To create a loop that operates on each item in a Dart collection, use the > `iterate` attribute in a `<template>` tag. Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:281: ### Listen to UI events On 2012/10/11 01:01:21, Kathy Walrath wrote: > -> ### Event listeners Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:308: ### Templating summary On 2012/10/11 01:01:21, Kathy Walrath wrote: > Templating summary -> Summary of templates > > (Having the "Summary" first is a visual cue. Plus you've used "template", not > "templating" before, so it's good to keep that consistent.) Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:312: model-view-viewmodel architecture. One-way data bindings, two-way data bindings, On 2012/10/11 01:01:21, Kathy Walrath wrote: > bindings -> binding > (twice in this line; to match what we used before) Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:313: and data-action listeners, help reduce the need for manually creating controller On 2012/10/11 01:01:21, Kathy Walrath wrote: > , help -> help Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:422: ### Working at scale On 2012/10/11 01:01:21, Kathy Walrath wrote: > -> ### Importing a component > > (to match the task orientation of previous headings in this section, plus give a > bit more info) Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:452: ### Upcoming features On 2012/10/11 01:01:21, Kathy Walrath wrote: > ### -> ## > > (since these features are for templates as well as components) Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:457: * Support for sub-components. Using a special `<content>` tag, a component On 2012/10/11 01:01:21, Kathy Walrath wrote: > GLOBAL: sub-component -> subcomponent > > (it's in the dictionary - I looked) wow - cool. Thanks :) https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:487: ## Developing and using Dart web components On 2012/10/11 01:01:21, Kathy Walrath wrote: > -> ## Tools for developing and using Dart web components > OR > ## Tools for Dart web components > > (having "Tools" first is very helpful) nice - done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:504: ## Exploring more On 2012/10/11 01:01:21, Kathy Walrath wrote: > ## Exploring more -> ## More information > OR > ## Resources > > (I wasn't sure what to expect from "Exploring more", plus it just sounded like > it was missing a word or two after "more") :), fixed https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/articles/... src/site/articles/dart-web-components/index.markdown:512: [issue tracker][bugs], and play with other examples in our repo, like our port On 2012/10/11 01:01:21, Kathy Walrath wrote: > like -> such as > > (in general, "like" is easy to misread. It has too many meanings.) Done. https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/css/style... File src/site/css/style.css (left): https://chromiumcodereview.appspot.com/11066080/diff/13008/src/site/css/style... src/site/css/style.css:13: >>>>>>> master this is what looked like a merge conflict initially :( |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
