tidy up PendingTask from previous change

Tidy up previous PendingTask change.

See discussion here: https://chromiumcodereview.appspot.com/11095007/


BUG=154744, 143646
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160811

[scottmg, 2012-10-09 03:58:51]

Since it might just need More Constructors :) make it explicitly VS2012 only so
it's not used mistakenly (and initialize members in any case).

[Ryan Sleevi, 2012-10-09 04:12:09]

LGTM - makes it clear this is a temporary thing.

http://codereview.chromium.org/11066071/diff/1/base/pending_task.h
File base/pending_task.h (right):

http://codereview.chromium.org/11066071/diff/1/base/pending_task.h#newcode21
base/pending_task.h:21: #if _MSC_VER == 1700
nit: >= ?

Mostly in the event of an service pack - I hope we don't see a new major MSVC
ver before this is fixed :)

[willchan no longer on Chromium, 2012-10-09 04:14:10]

lgtm, thanks for catching this ryan


On Mon, Oct 8, 2012 at 9:12 PM, <rsleevi@chromium.org> wrote:

> LGTM - makes it clear this is a temporary thing.
>
>
>
http://codereview.chromium.**org/11066071/diff/1/base/**pending_task.h<http:/...
> File base/pending_task.h (right):
>
> http://codereview.chromium.**org/11066071/diff/1/base/**
>
pending_task.h#newcode21<http://codereview.chromium.org/11066071/diff/1/base/pending_task.h#newcode21>
> base/pending_task.h:21: #if _MSC_VER == 1700
> nit: >= ?
>
> Mostly in the event of an service pack - I hope we don't see a new major
> MSVC ver before this is fixed :)
>
>
http://codereview.chromium.**org/11066071/<http://codereview.chromium.org/110...
>

[scottmg, 2012-10-09 04:24:28]

thanks

https://codereview.chromium.org/11066071/diff/1/base/pending_task.h
File base/pending_task.h (right):

https://codereview.chromium.org/11066071/diff/1/base/pending_task.h#newcode21
base/pending_task.h:21: #if _MSC_VER == 1700
On 2012/10/09 04:12:10, Ryan Sleevi wrote:
> nit: >= ?
> 
> Mostly in the event of an service pack - I hope we don't see a new major MSVC
> ver before this is fixed :)

Done.

[commit-bot: I haz the power, 2012-10-09 04:24:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/11066071/6001

[commit-bot: I haz the power, 2012-10-09 05:50:46]

Retried try job too often for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2012-10-09 08:16:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/11066071/6001

[commit-bot: I haz the power, 2012-10-09 09:37:42]

Change committed as 160811