Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 11066054: Build browser_process_sub_thread.cc on iOS. (Closed)

Created:
8 years, 2 months ago by msarda
Modified:
8 years, 2 months ago
Reviewers:
stuartmorgan, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Build browser_process_sub_thread.cc on iOS. Adds browser_process_sub_thread.cc to the build on iOS and ifdefs out BrowserChildProcessHostImpl::TerminateAll() as Chrome on iOS is single-process. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/browser_process_sub_thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msarda
PTAL.
8 years, 2 months ago (2012-10-08 13:31:00 UTC) #1
stuartmorgan
LGTM, but s/This CL adds browser_process_sub_thread.cc to the iOS section in content_browser.gypi and/Adds browser_process_sub_thread.cc to ...
8 years, 2 months ago (2012-10-08 13:45:00 UTC) #2
stuartmorgan
+jam for OWNERS for real this time.
8 years, 2 months ago (2012-10-08 13:45:17 UTC) #3
jam
lgtm
8 years, 2 months ago (2012-10-10 04:07:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/11066054/1
8 years, 2 months ago (2012-10-10 08:10:25 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-10 12:28:23 UTC) #6
Change committed as 161091

Powered by Google App Engine
This is Rietveld 408576698