Issue 11066054: Build browser_process_sub_thread.cc on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11066054: Build browser_process_sub_thread.cc on iOS. (Closed)

Created:
8 years, 2 months ago by msarda

Modified:
8 years, 2 months ago

Reviewers:
stuartmorgan, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Build browser_process_sub_thread.cc on iOS. Adds browser_process_sub_thread.cc to the build on iOS and ifdefs out BrowserChildProcessHostImpl::TerminateAll() as Chrome on iOS is single-process. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161091

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	content/browser/browser_process_sub_thread.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	content/content_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM, but s/This CL adds browser_process_sub_thread.cc to the iOS section in content_browser.gypi and/Adds browser_process_sub_thread.cc to ...

8 years, 2 months ago (2012-10-08 13:45:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/11066054/1

8 years, 2 months ago (2012-10-10 08:10:25 UTC) #5

Change committed as 161091

Expand Messages | Collapse Messages