Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2144)

Unified Diff: chrome/browser/resources/options/chromeos/internet_detail.html

Issue 11066015: Finish implementation of controlled setting indicator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/internet_detail.html
diff --git a/chrome/browser/resources/options/chromeos/internet_detail.html b/chrome/browser/resources/options/chromeos/internet_detail.html
index cf7fb886fa6192ec59f89087b2715b620da4409e..3da391f2fe851a266aec259e36da320eb4af45f8 100644
--- a/chrome/browser/resources/options/chromeos/internet_detail.html
+++ b/chrome/browser/resources/options/chromeos/internet_detail.html
@@ -72,8 +72,8 @@
<input id="prefer-network-wifi" type="checkbox">
<span i18n-content="inetPreferredNetwork"></span>
</label>
- <span class="controlled-setting-indicator" data="preferred"
- for="prefer-network-wifi"></span>
+ <span class="controlled-setting-indicator" type="checkbox"
+ data="preferred" for="prefer-network-wifi"></span>
</div>
</td>
</tr>
@@ -84,8 +84,8 @@
<input id="auto-connect-network-wifi" type="checkbox">
<span i18n-content="inetAutoConnectNetwork"></span>
</label>
- <span class="controlled-setting-indicator" data="autoConnect"
- for="auto-connect-network-wifi"></span>
+ <span class="controlled-setting-indicator" type="checkbox"
+ data="autoConnect" for="auto-connect-network-wifi"></span>
</div>
</td>
</tr>
@@ -163,8 +163,8 @@
<input id="auto-connect-network-wimax" type="checkbox">
<span i18n-content="inetAutoConnectNetwork"></span>
</label>
- <span class="controlled-setting-indicator" data="autoConnect"
- for="auto-connect-network-wimax"></span>
+ <span class="controlled-setting-indicator" type="checkbox"
+ data="autoConnect" for="auto-connect-network-wimax"></span>
</div>
</td>
</tr>
@@ -207,7 +207,7 @@
<td class="option-name" i18n-content="inetServerHostname"></td>
<td>
<input class="option-value" id="inet-server-hostname"></input>
- <span class="controlled-setting-indicator"
+ <span class="controlled-setting-indicator" type="text"
data="serverHostname" for="inet-server-hostname"></span>
</td>
</tr>
@@ -269,8 +269,8 @@
<option value="-1" i18n-content="cellularApnOther">
</option>
</select>
- <span class="controlled-setting-indicator" data="providerApnList"
- for="select-apn"></span>
+ <span class="controlled-setting-indicator" type="select"
+ data="providerApnList" for="select-apn"></span>
</td>
</tr>
<tr class="gsm-only apn-details-view">
@@ -309,8 +309,8 @@
<input id="auto-connect-network-cellular" type="checkbox">
<span i18n-content="inetAutoConnectNetwork"></span>
</label>
- <span class="controlled-setting-indicator" data="autoConnect"
- for="auto-connect-network-cellular"></span>
+ <span class="controlled-setting-indicator" type="checkbox"
+ data="autoConnect" for="auto-connect-network-cellular"></span>
</div>
</td>
</tr>
@@ -388,8 +388,8 @@
type="checkbox">
<span i18n-content="ipAutomaticConfiguration"></span>
</label>
- <span class="controlled-setting-indicator" data="ipconfigDHCP"
- for="ip-automatic-configuration"></span>
+ <span class="controlled-setting-indicator" type="checkbox"
+ data="ipconfigDHCP" for="ip-automatic-configuration"></span>
</div>
<div>
<table id="ip-address-settings">
@@ -474,15 +474,15 @@
<input id="sim-card-lock-enabled" type="checkbox">
<span i18n-content="lockSimCard"></span>
</label>
- <span class="controlled-setting-indicator" data="simCardLockEnabled"
- for="sim-card-lock-enabled"></span>
+ <span class="controlled-setting-indicator" type="checkbox"
+ data="simCardLockEnabled" for="sim-card-lock-enabled"></span>
</div>
</section>
<section>
<div id="change-pin-area">
<button id="change-pin" i18n-content="changePinButton"></button>
- <span class="controlled-setting-indicator" data="simCardLockEnabled"
- for="change-pin"></span>
+ <span class="controlled-setting-indicator" type="button"
+ data="simCardLockEnabled" for="change-pin"></span>
</div>
</section>
</div>

Powered by Google App Engine
This is Rietveld 408576698