Issue 11065035: Don't make base/net/ui depend on their Java counterpart when building for webview.

Issue 11065035: Don't make base/net/ui depend on their Java counterpart when building for webview. (Closed)

Created:
8 years, 2 months ago by Philippe

Modified:
8 years, 2 months ago

Reviewers:
Torne

CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't make base/net/ui depend on their Java counterpart when building for webview. This is needed to build Android webview. TBR=brettw,willchan,sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160390

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
M	base/base.gyp	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	net/net.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/ui.gyp	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

Philippe

On 2012/10/05 12:11:05, Torne wrote: > ui also depends on ui_java and needs the same ...

8 years, 2 months ago (2012-10-05 12:34:04 UTC) #3

Philippe

On 2012/10/05 12:42:30, Torne wrote: > lgtm Thanks Richard. Do you think a TBR= is ...

8 years, 2 months ago (2012-10-05 12:46:00 UTC) #5

Torne

On 2012/10/05 12:46:00, Philippe wrote: > On 2012/10/05 12:42:30, Torne wrote: > > lgtm > ...

8 years, 2 months ago (2012-10-05 12:47:33 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11065035/5002

8 years, 2 months ago (2012-10-05 12:59:09 UTC) #7

Change committed as 160390