Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 11065007: Use the correct inputs when checking if inverse operator can be used. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index db2c5005505abe97003b41478f0f41ecaa7b6768..e2ca6a9953ccf2a2bbb36bacfaeb0f7e16747fb5 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -1817,9 +1817,9 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
">=" : "<"
};
HRelational relational = input;
-
- visitInvokeBinary(input,
- inverseOperator[relational.operation.name.stringValue]);
+ // TODO(ngeoffray): is this code ever exercised in a test?
ngeoffray 2012/10/04 09:39:05 Why is that a TODO on me?
karlklose 2012/10/04 10:06:08 I thought that you wrote the code. I will change i
+ BinaryOperation operation = relational.operation(backend.constantSystem);
+ visitInvokeBinary(input, inverseOperator[operation.name.stringValue]);
} else {
use(input);
push(new js.Prefix("!", pop()));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698