[Chromoting] Update remoting version numbering pattern

[Chromoting] Update remoting version numbering pattern.

To make it easier to patch Chromoting without updating Chrome's version, we're switching to use: major.branch.patch.remoting_patch, where |remoting_patch| is 0 unless we need to patch a release.

For reference, Chrome uses major.minor.branch.patch, but |minor| is always 0.

This cl also adds the ability to override Chrome's |major|, |branch|, and |patch| values with Chromoting-specific ones.

BUG=153462
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160992

[Wez, 2012-10-05 00:56:43]

LGTM w/ nit.

Please add BUG=153462 to the description.

http://codereview.chromium.org/11058004/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/11058004/diff/1/remoting/remoting.gyp#newcode26
remoting/remoting.gyp:26: '<!(python <(version_py_path) -f
<(chrome_version_path) -t "@BUILD@.@PATCH@")',
nit: Pull out version_build to make these two more readable.

[Wez, 2012-10-05 03:10:17]

On 2012/10/05 00:56:43, Wez wrote:
> LGTM w/ nit.
> 
> Please add BUG=153462 to the description.
> 
> http://codereview.chromium.org/11058004/diff/1/remoting/remoting.gyp
> File remoting/remoting.gyp (right):
> 
> http://codereview.chromium.org/11058004/diff/1/remoting/remoting.gyp#newcode26
> remoting/remoting.gyp:26: '<!(python <(version_py_path) -f
> <(chrome_version_path) -t "@BUILD@.@PATCH@")',
> nit: Pull out version_build to make these two more readable.

Actually, let's go with <major>.<build>.<patch>.<remoting-specific>, please.

[garykac, 2012-10-09 18:08:17]

+alexeypa for Window changes

[alexeypa (please no reviews), 2012-10-09 18:28:18]

http://codereview.chromium.org/11058004/diff/9001/remoting/VERSION
File remoting/VERSION (right):

http://codereview.chromium.org/11058004/diff/9001/remoting/VERSION#newcode1
remoting/VERSION:1: CHROMOTOPATCH=0
nit: Why not CHROMOTING_PATCH?

http://codereview.chromium.org/11058004/diff/9001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/11058004/diff/9001/remoting/remoting.gyp#newco...
remoting/remoting.gyp:683: '<(remoting_version_path)',
nit: sort these alphabetically.

http://codereview.chromium.org/11058004/diff/9001/remoting/remoting.gyp#newco...
remoting/remoting.gyp:696: '-f', '<(remoting_version_path)',
nit: add a comment saying the the order is important here.

[alexeypa (please no reviews), 2012-10-09 18:28:25]

lgtm

[Wez, 2012-10-09 18:31:08]

http://codereview.chromium.org/11058004/diff/9001/remoting/VERSION
File remoting/VERSION (right):

http://codereview.chromium.org/11058004/diff/9001/remoting/VERSION#newcode1
remoting/VERSION:1: CHROMOTOPATCH=0
On 2012/10/09 18:28:18, alexeypa wrote:
> nit: Why not CHROMOTING_PATCH?

nit: REMOTING_PATCH, to match the naming of the directory & file.

[garykac, 2012-10-09 18:51:55]

http://codereview.chromium.org/11058004/diff/9001/remoting/VERSION
File remoting/VERSION (right):

http://codereview.chromium.org/11058004/diff/9001/remoting/VERSION#newcode1
remoting/VERSION:1: CHROMOTOPATCH=0
On 2012/10/09 18:31:08, Wez wrote:
> On 2012/10/09 18:28:18, alexeypa wrote:
> > nit: Why not CHROMOTING_PATCH?
> 
> nit: REMOTING_PATCH, to match the naming of the directory & file.

Done.

http://codereview.chromium.org/11058004/diff/9001/remoting/VERSION#newcode1
remoting/VERSION:1: CHROMOTOPATCH=0
On 2012/10/09 18:28:18, alexeypa wrote:
> nit: Why not CHROMOTING_PATCH?

Done.

http://codereview.chromium.org/11058004/diff/9001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/11058004/diff/9001/remoting/remoting.gyp#newco...
remoting/remoting.gyp:683: '<(remoting_version_path)',
On 2012/10/09 18:28:18, alexeypa wrote:
> nit: sort these alphabetically.

Done.

http://codereview.chromium.org/11058004/diff/9001/remoting/remoting.gyp#newco...
remoting/remoting.gyp:696: '-f', '<(remoting_version_path)',
On 2012/10/09 18:28:18, alexeypa wrote:
> nit: add a comment saying the the order is important here.

Done.

[commit-bot: I haz the power, 2012-10-09 22:53:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/11058004/16001

[commit-bot: I haz the power, 2012-10-10 00:13:48]

Change committed as 160992