[Android] Set a default locale for WebView.

[Android] Set a default locale for WebView.

Recent WebKit rolls have introduced an assertion for the default language that is causing
some failures in WebView. The reason is that the default locale is not properly iset in
single process mode. However, since this will probably require more elaborate solution
we'll be setting a value manually for now to unblock tests and prevent further issues.

BUG=153758
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159899

[mkosiba (inactive), 2012-10-03 13:04:35]

lgtm

[commit-bot: I haz the power, 2012-10-03 13:07:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/11054012/1

[commit-bot: I haz the power, 2012-10-03 13:07:51]

Presubmit check for 11054012-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    android_webview/lib

[Leandro Graciá Gil, 2012-10-03 13:09:32]

Looks like we'll need a lib owner. Torne, could you have a look?

[benm (inactive), 2012-10-03 13:10:05]

https://codereview.chromium.org/11054012/diff/1/android_webview/lib/DEPS
File android_webview/lib/DEPS (right):

https://codereview.chromium.org/11054012/diff/1/android_webview/lib/DEPS#newc...
android_webview/lib/DEPS:32: "+ui/base/ui_base_switches.h",
this should be a '!' shouldn't it?

[benm (inactive), 2012-10-03 13:10:48]

https://codereview.chromium.org/11054012/diff/1/android_webview/lib/main/webv...
File android_webview/lib/main/webview_entry_point.cc (right):

https://codereview.chromium.org/11054012/diff/1/android_webview/lib/main/webv...
android_webview/lib/main/webview_entry_point.cc:33: // and should be propery
fixed. See bug 153758.
sp properly

[Leandro Graciá Gil, 2012-10-03 13:14:31]

https://codereview.chromium.org/11054012/diff/1/android_webview/lib/DEPS
File android_webview/lib/DEPS (right):

https://codereview.chromium.org/11054012/diff/1/android_webview/lib/DEPS#newc...
android_webview/lib/DEPS:32: "+ui/base/ui_base_switches.h",
On 2012/10/03 13:10:05, benm wrote:
> this should be a '!' shouldn't it?

Used + to prevent the presubmit warning, but as discussed it should be right.

https://codereview.chromium.org/11054012/diff/1/android_webview/lib/main/webv...
File android_webview/lib/main/webview_entry_point.cc (right):

https://codereview.chromium.org/11054012/diff/1/android_webview/lib/main/webv...
android_webview/lib/main/webview_entry_point.cc:33: // and should be propery
fixed. See bug 153758.
On 2012/10/03 13:10:48, benm wrote:
> sp properly

Done.

[Torne, 2012-10-03 13:18:06]

lgtm

[commit-bot: I haz the power, 2012-10-03 13:21:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/11054012/4002

[Leandro Graciá Gil, 2012-10-03 14:48:02]

On 2012/10/03 13:21:43, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>
https://chromium-status.appspot.com/cq/leandrogracia%40chromium.org/11054012/...

All android bots (dbg, fyi + triggered tests) are happy. Landing this now.

[commit-bot: I haz the power, 2012-10-03 14:48:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/11054012/4002

[commit-bot: I haz the power, 2012-10-03 15:44:35]

Change committed as 159899

[joth, 2012-10-03 16:28:48]

lgtm - thanks for jumping on this.



On 3 October 2012 08:44, <commit-bot@chromium.org> wrote:

> Change committed as 159899
>
>
https://chromiumcodereview.**appspot.com/11054012/<https://chromiumcodereview...
>
> --
>
>
>