Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: chrome/browser/extensions/app_shortcut_manager.cc

Issue 11054006: Make application shortcuts point to app_host.exe, install App Host during app installation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Adding app_host_installer_win.*; using WeakPtrFactory in AppShortcutManager. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_shortcut_manager.cc
diff --git a/chrome/browser/extensions/app_shortcut_manager.cc b/chrome/browser/extensions/app_shortcut_manager.cc
index 7d1f275403cd833be7008724a10510d3192e9fde..aebef8373ccc692fec709532c725ff1fab4ec3aa 100644
--- a/chrome/browser/extensions/app_shortcut_manager.cc
+++ b/chrome/browser/extensions/app_shortcut_manager.cc
@@ -4,7 +4,9 @@
#include "chrome/browser/extensions/app_shortcut_manager.h"
+#include "base/bind.h"
#include "base/command_line.h"
+#include "base/logging.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/web_applications/web_app.h"
@@ -17,6 +19,10 @@
#include "skia/ext/image_operations.h"
#include "ui/base/resource/resource_bundle.h"
+#if defined(OS_WIN)
+#include "chrome/browser/extensions/app_host_installer_win.h"
+#endif
+
namespace extensions {
namespace {
@@ -45,7 +51,8 @@ ShellIntegration::ShortcutInfo ShortcutInfoForExtensionAndProfile(
} // namespace
AppShortcutManager::AppShortcutManager(Profile* profile)
- : profile_(profile),
+ : ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
erikwright (departed) 2012/11/02 20:40:59 #include "base/compiler_specific.h"
huangs 2012/11/02 22:15:33 Done.
+ profile_(profile),
tracker_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_INSTALLED,
content::Source<Profile>(profile_));
@@ -81,8 +88,15 @@ void AppShortcutManager::Observe(int type,
case chrome::NOTIFICATION_EXTENSION_INSTALLED: {
const Extension* extension = content::Details<const Extension>(
details).ptr();
- if (extension->is_platform_app())
+ if (extension->is_platform_app()) {
+#if defined(OS_WIN)
+ extensions::AppHostInstaller::EnsureAppHostInstalled(
+ base::Bind(&AppShortcutManager::OnAppHostInstallationComplete,
+ weak_factory_.GetWeakPtr(), extension));
+#else
UpdateApplicationShortcuts(extension);
+#endif
+ }
break;
}
case chrome::NOTIFICATION_EXTENSION_UNINSTALLED: {
@@ -97,6 +111,18 @@ void AppShortcutManager::Observe(int type,
#endif
}
+#if defined(OS_WIN)
+void AppShortcutManager::OnAppHostInstallationComplete(
+ const Extension* extension, bool app_host_install_success) {
+ if (!app_host_install_success) {
+ // Do not create shortcuts if App Host fails to install.
+ LOG(ERROR) << "Application Runtime installation failed.";
+ return;
+ }
+ UpdateApplicationShortcuts(extension);
+}
+#endif
+
void AppShortcutManager::UpdateApplicationShortcuts(
const Extension* extension) {
shortcut_info_ = ShortcutInfoForExtensionAndProfile(extension, profile_);

Powered by Google App Engine
This is Rietveld 408576698