Make application shortcuts point to app_host.exe, install App Host during app installation.

chrome/browser/extensions/crx_installer.cc

Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index d1f2a77c1f21132033696985f1e761549670cf66..c20aad8c3a173f96a110350a947a82337c55eb72 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -21,6 +21,7 @@
 #include "base/utf_string_conversions.h"
 #include "base/version.h"
 #include "chrome/browser/browser_process.h"
+#include "chrome/browser/extensions/app_host_installer.h"
 #include "chrome/browser/extensions/convert_user_script.h"
 #include "chrome/browser/extensions/convert_web_app.h"
 #include "chrome/browser/extensions/default_apps_trial.h"
@@ -457,7 +458,7 @@ void CrxInstaller::ConfirmInstall() {
   } else {
     if (!BrowserThread::PostTask(
             BrowserThread::FILE, FROM_HERE,
-            base::Bind(&CrxInstaller::CompleteInstall, this)))
+            base::Bind(&CrxInstaller::BeginInstall, this)))
       NOTREACHED();
   }
   return;
@@ -466,7 +467,7 @@ void CrxInstaller::ConfirmInstall() {
 void CrxInstaller::InstallUIProceed() {
   if (!BrowserThread::PostTask(
           BrowserThread::FILE, FROM_HERE,
-          base::Bind(&CrxInstaller::CompleteInstall, this)))
+          base::Bind(&CrxInstaller::BeginInstall, this)))
     NOTREACHED();
 
   Release();  // balanced in ConfirmInstall().
@@ -494,7 +495,7 @@ void CrxInstaller::InstallUIAbort(bool user_initiated) {
   // should go to zero and we die. The destructor will clean up the temp dir.
 }
 
-void CrxInstaller::CompleteInstall() {
+void CrxInstaller::BeginInstall() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
   if (!current_version_.empty()) {
@@ -508,6 +509,28 @@ void CrxInstaller::CompleteInstall() {
       return;
     }
   }
+  if (AppHostInstaller::IsAppHostInstallRequired(*extension_)) {
+    AddRef();  // Balanced in OnAppHostInstallation().

[erikwright (departed), 2012/10/03 20:57:07]

I don't think that this is required. You're binding a ref_ptr to this in the
callback, so you are already AddRef'd.

[huangs, 2012/10/04 00:53:14]

Done; deleted corresponding Release(), too.

+    app_host_installer_.InstallAppHost(
+        base::Bind(&CrxInstaller::OnAppHostInstallation, this));
+  } else {
+    CompleteInstall();
+  }
+}
+
+void CrxInstaller::OnAppHostInstallation(bool success) {
+  Release();  // Balanced in BeginInstall().
+  if (success) {
+    CompleteInstall();
+  } else {
+    // TODO(huangs): Error message.
+    string16 error = L"Some random error message";
+    ReportFailureFromFileThread(CrxInstallerError(error));
+  }
+}
+
+void CrxInstaller::CompleteInstall() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
   // See how long extension install paths are.  This is important on
   // windows, because file operations may fail if the path to a file