Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: chrome/browser/extensions/app_host_installer.h

Issue 11054006: Make application shortcuts point to app_host.exe, install App Host during app installation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Changed AppHostInstaller interface; handled thread compilcation in AppHostInstaller; added error me… Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_host_installer.h
diff --git a/chrome/browser/extensions/app_host_installer.h b/chrome/browser/extensions/app_host_installer.h
new file mode 100644
index 0000000000000000000000000000000000000000..8cd6e2647994f25f9095ccc518bc5fea732aecbc
--- /dev/null
+++ b/chrome/browser/extensions/app_host_installer.h
@@ -0,0 +1,37 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_APP_HOST_INSTALLER_H_
+#define CHROME_BROWSER_EXTENSIONS_APP_HOST_INSTALLER_H_
+
+#include "base/basictypes.h"
+#include "base/callback_forward.h"
+
+namespace extensions {
+
+class Extension;
+class AppHostInstallerImpl;
+
+class AppHostInstaller {
+ public:
+ AppHostInstaller();
+ ~AppHostInstaller();
+
+ // Installs App Host, then calls (directly or via post) |next_step|
erikwright (departed) 2012/10/05 02:21:56 Installs the App Host if it is required and not pr
huangs 2012/10/05 19:46:08 Done.
+ // to proceed with installation, on the caller thread.
+ // |next_step| takes a bool parameter to be notified of whether or not
+ // App Host installation was successful.
+ void AppHostInstaller::InstallAppHostIfNecessaryThenCall(
erikwright (departed) 2012/10/05 02:21:56 Remove the "ThenCall". The presence of a callback
huangs 2012/10/05 19:46:08 Done.
+ const Extension& extension,
+ const base::Callback<void(bool)>& final_step);
+
+ private:
+ // The implementation.
+ AppHostInstallerImpl* impl_;
huangs 2012/10/04 22:56:42 Not using scoped_ptr for this, since AppHostInstal
+ DISALLOW_COPY_AND_ASSIGN(AppHostInstaller);
+};
+
+} // namespace extensions
+
+#endif // CHROME_BROWSER_EXTENSIONS_APP_HOST_INSTALLER_H_

Powered by Google App Engine
This is Rietveld 408576698