Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: chrome/browser/extensions/unpacked_installer.h

Issue 11054006: Make application shortcuts point to app_host.exe, install App Host during app installation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rearranged code for unpacked_installer.cc; moved App Host code from chrome_launch_support to app_ho… Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/unpacked_installer.h
diff --git a/chrome/browser/extensions/unpacked_installer.h b/chrome/browser/extensions/unpacked_installer.h
index 6b48857aecdb039279a992d392c49f8c72063755..370fa6711f7b7c1c30e0b0e452e4cf5b0dc5679d 100644
--- a/chrome/browser/extensions/unpacked_installer.h
+++ b/chrome/browser/extensions/unpacked_installer.h
@@ -12,6 +12,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
+#include "chrome/browser/extensions/app_host_installer.h"
class ExtensionService;
@@ -87,6 +88,20 @@ class UnpackedInstaller
// Called when an unpacked extension has been loaded and installed.
void OnLoaded();
+ // Called when user commits to intalling an app.
+ void OnPromptAccepted();
+
+ // Runs on File thread. Ensures that App Host is installed, and then
benwells 2012/10/04 07:53:01 Nit: File -> FILE
huangs 2012/10/04 22:56:42 Done (for the file).
+ // proceeds to post CompleteExtensionInstall().
+ void BeginInstall();
+
+ // Callback function for AppHostInstaller.
+ void OnAppHostInstallation(bool success);
+
+ // Runs on File thread. Installs the unpacked extension into the profile and
benwells 2012/10/04 07:53:01 Nit: File -> FILE
huangs 2012/10/04 22:56:42 Done.
+ // notifies the frontend.
+ void CompleteInstall();
+
// Helper to get the Extension::CreateFlags for the installing extension.
int GetFlags();
@@ -108,6 +123,9 @@ class UnpackedInstaller
// version.
bool require_modern_manifest_version_;
+ // Helper to install App Host.
+ AppHostInstaller app_host_installer_;
+
DISALLOW_COPY_AND_ASSIGN(UnpackedInstaller);
};

Powered by Google App Engine
This is Rietveld 408576698