Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 11054005: ash: Display system background while loading wallpaper. (Closed)

Created:
8 years, 2 months ago by Daniel Erat
Modified:
8 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Nikita (slow), bshe, James Cook
Visibility:
Public.

Description

ash: Display system background while loading wallpaper. When the wallpaper takes a long time to load, areas of the screen that aren't covered by other layers are painted white. This looks okay when we first boot, but not when we're displaying the login after logging out or while we're starting a guest session. This makes us instead initialize SystemBackgroundController immediately with either a #fefefe or black color depending on whether this is the first Chrome run after boot or not. Its color is updated to black after the login wallpaper animation is finished. BUG=151111, 152751 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159822

Patch Set 1 #

Patch Set 2 : update comment #

Patch Set 3 : fix win_aura compile, hopefully #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -39 lines) Patch
M ash/desktop_background/desktop_background_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/root_window_controller.h View 3 chunks +15 lines, -1 line 0 comments Download
M ash/root_window_controller.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/shell_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/shell_window_ids.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/workspace/system_background_controller.h View 2 chunks +6 lines, -1 line 0 comments Download
M ash/wm/workspace/system_background_controller.cc View 4 chunks +11 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager2.h View 3 chunks +0 lines, -12 lines 0 comments Download
M ash/wm/workspace/workspace_manager2.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
8 years, 2 months ago (2012-10-02 22:10:26 UTC) #1
sky
LGTM
8 years, 2 months ago (2012-10-02 22:21:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11054005/6001
8 years, 2 months ago (2012-10-02 23:21:45 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-03 01:15:11 UTC) #4
Change committed as 159822

Powered by Google App Engine
This is Rietveld 408576698