Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/chromeos/login/webui_login_view.cc

Issue 11052015: Fix bug with login-prompt-visible not being sent in some rare cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: build Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/webui_login_view.cc
diff --git a/chrome/browser/chromeos/login/webui_login_view.cc b/chrome/browser/chromeos/login/webui_login_view.cc
index a91f914de323308abe97b0a4c62cf756f2db8a13..f70a926decac08bdaabe22bf9b60c553bd871bdf 100644
--- a/chrome/browser/chromeos/login/webui_login_view.cc
+++ b/chrome/browser/chromeos/login/webui_login_view.cc
@@ -117,7 +117,6 @@ WebUILoginView::WebUILoginView()
login_window_(NULL),
host_window_frozen_(false),
is_hidden_(false),
- login_visible_notification_fired_(false),
login_prompt_visible_handled_(false),
should_emit_login_prompt_visible_(true) {
registrar_.Add(this,
@@ -239,11 +238,7 @@ void WebUILoginView::OpenProxySettings() {
void WebUILoginView::OnPostponedShow() {
set_is_hidden(false);
- // If notification will happen later let it fire login-prompt-visible signal.
- if (login_visible_notification_fired_) {
- LOG(INFO) << "Login WebUI >> postponed show, login_visible already fired";
- OnLoginPromptVisible();
- }
+ OnLoginPromptVisible();
}
void WebUILoginView::SetStatusAreaVisible(bool visible) {
@@ -285,7 +280,6 @@ void WebUILoginView::Observe(int type,
const content::NotificationDetails& details) {
switch (type) {
case chrome::NOTIFICATION_LOGIN_WEBUI_VISIBLE: {
- login_visible_notification_fired_ = true;
OnLoginPromptVisible();
registrar_.RemoveAll();
break;
« no previous file with comments | « chrome/browser/chromeos/login/webui_login_view.h ('k') | chrome/browser/resources/chromeos/login/demo_user_login.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698