Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: lib/compiler/implementation/js_backend/emitter.dart

Issue 11052011: Fix some warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/js_backend/emitter.dart
diff --git a/lib/compiler/implementation/js_backend/emitter.dart b/lib/compiler/implementation/js_backend/emitter.dart
index d57a1ba9e05797e63d255d52c8dc4377a1566c4a..1abe9785b4420ecbcdcce1645107b307db2a7335 100644
--- a/lib/compiler/implementation/js_backend/emitter.dart
+++ b/lib/compiler/implementation/js_backend/emitter.dart
@@ -552,7 +552,7 @@ function(prototype, staticName, fieldName, getterName, lazyValue) {
return null;
} else {
SourceString helper = compiler.backend.getCheckedModeHelper(type);
- Element helperElement = compiler.findHelper(helper);
+ FunctionElement helperElement = compiler.findHelper(helper);
ahe 2012/10/03 14:56:33 findHelper isn't guaranteed to return a function e
karlklose 2012/10/04 08:50:00 I added a TODO to findHelper.
String helperName = namer.isolateAccess(helperElement);
String additionalArgument = '';
if (helperElement.computeSignature(compiler).parameterCount != 1) {
@@ -670,7 +670,7 @@ function(prototype, staticName, fieldName, getterName, lazyValue) {
}
});
- generateIsTestsOn(classElement, (Element other) {
+ generateIsTestsOn(classElement, (ClassElement other) {
String code;
if (other.isObject(compiler)) return;
if (nativeEmitter.requiresNativeIsCheck(other)) {

Powered by Google App Engine
This is Rietveld 408576698