Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11052007: Rename ModelType/ObjectIdStateMap to InvalidationMap. (Closed)

Created:
8 years, 2 months ago by dcheng
Modified:
8 years, 2 months ago
Reviewers:
akalin
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, akalin, Raghu Simha, Aaron Boodman, haitaol1, tim (not reviewing)
Visibility:
Public.

Description

Rename ModelType/ObjectIdStateMap to InvalidationMap. BUG=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160073

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 12

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+708 lines, -1466 lines) Patch
M chrome/browser/chrome_to_mobile_service.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/bridged_invalidator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bridged_invalidator.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/bridged_invalidator_unittest.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/chrome_sync_notification_bridge.cc View 1 2 3 3 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc View 1 2 3 6 chunks +30 lines, -28 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sync/engine/download_updates_command.cc View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M sync/engine/sync_scheduler.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sync/engine/sync_scheduler_impl.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M sync/engine/sync_scheduler_impl.cc View 1 2 6 chunks +16 lines, -16 lines 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 1 2 16 chunks +27 lines, -26 lines 0 comments Download
M sync/engine/sync_scheduler_whitebox_unittest.cc View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M sync/engine/syncer_unittest.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M sync/internal_api/debug_info_event_listener.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/debug_info_event_listener.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sync/internal_api/public/base/invalidation.h View 3 chunks +10 lines, -5 lines 0 comments Download
A + sync/internal_api/public/base/invalidation.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D sync/internal_api/public/base/invalidation_state.h View 1 chunk +0 lines, -45 lines 0 comments Download
D sync/internal_api/public/base/invalidation_state.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D sync/internal_api/public/base/invalidation_state_test_util.h View 1 chunk +0 lines, -23 lines 0 comments Download
D sync/internal_api/public/base/invalidation_state_test_util.cc View 1 chunk +0 lines, -63 lines 0 comments Download
A + sync/internal_api/public/base/invalidation_test_util.h View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
A + sync/internal_api/public/base/invalidation_test_util.cc View 1 2 3 2 chunks +18 lines, -18 lines 0 comments Download
A + sync/internal_api/public/base/model_type_invalidation_map.h View 1 2 2 chunks +18 lines, -19 lines 0 comments Download
A + sync/internal_api/public/base/model_type_invalidation_map.cc View 1 2 3 chunks +21 lines, -19 lines 0 comments Download
A + sync/internal_api/public/base/model_type_invalidation_map_test_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + sync/internal_api/public/base/model_type_invalidation_map_test_util.cc View 4 chunks +24 lines, -21 lines 0 comments Download
A + sync/internal_api/public/base/model_type_invalidation_map_unittest.cc View 3 chunks +11 lines, -11 lines 0 comments Download
D sync/internal_api/public/base/model_type_state_map.h View 1 chunk +0 lines, -54 lines 0 comments Download
D sync/internal_api/public/base/model_type_state_map.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D sync/internal_api/public/base/model_type_state_map_test_util.h View 1 chunk +0 lines, -20 lines 0 comments Download
D sync/internal_api/public/base/model_type_state_map_test_util.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D sync/internal_api/public/base/model_type_state_map_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker_unittest.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.h View 4 chunks +4 lines, -4 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M sync/internal_api/public/sessions/sync_source_info.h View 2 chunks +4 lines, -4 lines 0 comments Download
M sync/internal_api/public/sessions/sync_source_info.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/test/fake_sync_manager.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 2 5 chunks +19 lines, -17 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M sync/internal_api/test/fake_sync_manager.cc View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M sync/notifier/fake_invalidation_handler.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M sync/notifier/fake_invalidation_handler.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M sync/notifier/fake_invalidator.h View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M sync/notifier/fake_invalidator.cc View 1 2 3 chunks +8 lines, -6 lines 0 comments Download
M sync/notifier/fake_invalidator_unittest.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M sync/notifier/invalidation_handler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sync/notifier/invalidation_notifier.h View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M sync/notifier/invalidation_notifier.cc View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M sync/notifier/invalidation_notifier_unittest.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M sync/notifier/invalidator.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M sync/notifier/invalidator_registrar.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M sync/notifier/invalidator_registrar.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sync/notifier/invalidator_registrar_unittest.cc View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M sync/notifier/invalidator_test_template.h View 1 2 3 7 chunks +14 lines, -21 lines 0 comments Download
M sync/notifier/non_blocking_invalidator.h View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M sync/notifier/non_blocking_invalidator.cc View 1 2 3 4 chunks +8 lines, -7 lines 0 comments Download
M sync/notifier/non_blocking_invalidator_unittest.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
A + sync/notifier/object_id_invalidation_map.h View 1 2 2 chunks +28 lines, -26 lines 0 comments Download
A + sync/notifier/object_id_invalidation_map.cc View 1 2 4 chunks +45 lines, -42 lines 0 comments Download
A + sync/notifier/object_id_invalidation_map_test_util.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + sync/notifier/object_id_invalidation_map_test_util.cc View 4 chunks +24 lines, -20 lines 0 comments Download
D sync/notifier/object_id_state_map.h View 1 chunk +0 lines, -49 lines 0 comments Download
D sync/notifier/object_id_state_map.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D sync/notifier/object_id_state_map_test_util.h View 1 chunk +0 lines, -20 lines 0 comments Download
D sync/notifier/object_id_state_map_test_util.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M sync/notifier/p2p_invalidator.h View 1 4 chunks +6 lines, -5 lines 0 comments Download
M sync/notifier/p2p_invalidator.cc View 1 13 chunks +23 lines, -19 lines 0 comments Download
M sync/notifier/p2p_invalidator_unittest.cc View 1 2 10 chunks +48 lines, -50 lines 0 comments Download
M sync/notifier/sync_invalidation_listener.h View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M sync/notifier/sync_invalidation_listener.cc View 1 2 3 3 chunks +11 lines, -14 lines 0 comments Download
M sync/notifier/sync_invalidation_listener_unittest.cc View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
M sync/sessions/session_state_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M sync/sessions/sync_session.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M sync/sessions/sync_session_unittest.cc View 1 2 5 chunks +20 lines, -20 lines 0 comments Download
M sync/sync.gyp View 5 chunks +13 lines, -13 lines 0 comments Download
M sync/test/engine/fake_sync_scheduler.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sync/test/engine/fake_sync_scheduler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sync/test/engine/mock_connection_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M sync/test/engine/syncer_command_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 2 3 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
I also did some simplification and cleanup of variable names. In general, x/y_invalidation_map -> invalidation_map. ...
8 years, 2 months ago (2012-10-03 21:00:55 UTC) #1
akalin
LGTM after nits http://codereview.chromium.org/11052007/diff/4001/chrome/browser/sync/glue/chrome_sync_notification_bridge.cc File chrome/browser/sync/glue/chrome_sync_notification_bridge.cc (right): http://codereview.chromium.org/11052007/diff/4001/chrome/browser/sync/glue/chrome_sync_notification_bridge.cc#newcode202 chrome/browser/sync/glue/chrome_sync_notification_bridge.cc:202: // ObjectIdINvalidationMap. N -> n http://codereview.chromium.org/11052007/diff/4001/chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc ...
8 years, 2 months ago (2012-10-04 00:55:31 UTC) #2
dcheng
http://codereview.chromium.org/11052007/diff/4001/chrome/browser/sync/glue/chrome_sync_notification_bridge.cc File chrome/browser/sync/glue/chrome_sync_notification_bridge.cc (right): http://codereview.chromium.org/11052007/diff/4001/chrome/browser/sync/glue/chrome_sync_notification_bridge.cc#newcode202 chrome/browser/sync/glue/chrome_sync_notification_bridge.cc:202: // ObjectIdINvalidationMap. On 2012/10/04 00:55:31, akalin wrote: > N ...
8 years, 2 months ago (2012-10-04 01:12:30 UTC) #3
dcheng
TBRing the chrome/browser/chrome_to_mobile_service.* changes since they are trivial and the rest is already covered.
8 years, 2 months ago (2012-10-04 01:14:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/11052007/12002
8 years, 2 months ago (2012-10-04 01:14:35 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-04 03:53:15 UTC) #6 
Change committed as 160073

Powered by Google App Engine
This is Rietveld 408576698