Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 11051029: [cc] Fix zebra-stripe compositor checkerboarding (Closed)

Created:
8 years, 2 months ago by enne (OOO)
Modified:
8 years, 2 months ago
Reviewers:
jamesr, marcheu
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] Fix zebra-stripe compositor checkerboarding It seems likely that medium precision floating point uniforms on some hardware are running out of precision. Fix in the short term by doing an int mod of the texture coordinate prior to setting the uniform. BUG=150829 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M cc/CCRendererGL.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
enne (OOO)
I couldn't repro this on desktop, but this seems super likely to be the problem ...
8 years, 2 months ago (2012-10-03 22:35:26 UTC) #1
jamesr
lgtm. I'll try this out on a snow
8 years, 2 months ago (2012-10-03 22:42:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11051029/1
8 years, 2 months ago (2012-10-03 22:46:14 UTC) #3
jamesr
On 2012/10/03 22:42:49, jamesr wrote: > lgtm. I'll try this out on a snow Seems ...
8 years, 2 months ago (2012-10-03 22:52:21 UTC) #4
commit-bot: I haz the power
Change committed as 160030
8 years, 2 months ago (2012-10-04 01:01:57 UTC) #5
marcheu
Could we try on pineview? We don't have integers (they're not part of GL 2.0 ...
8 years, 2 months ago (2012-10-04 01:08:41 UTC) #6
marcheu
8 years, 2 months ago (2012-10-04 01:09:19 UTC) #7
Ah nevermind it's not shader code :)

Powered by Google App Engine
This is Rietveld 408576698