Remove Legacy NPAPI Flash Sandbox support

Remove Legacy NPAPI Flash Sandbox support

BUG=153599
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160310

[jschuh, 2012-10-02 21:56:42]

@cpu and @ananta to make sure I didn't do anything stupid.
@brettw as owner.

[cpu_(ooo_6.6-7.5), 2012-10-04 17:46:40]

awesome cleanup. lgtm.

http://codereview.chromium.org/11049004/diff/2002/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_base.cc (left):

http://codereview.chromium.org/11049004/diff/2002/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_base.cc:152: if
(::GetPropW(orig_parent, webkit::npapi::kNativeWindowClassFilterProp)) {
the constant webkit::npapi::kNativeWindowClassFilterProp can be removed.

http://codereview.chromium.org/11049004/diff/2002/content/common/sandbox_poli...
File content/common/sandbox_policy.cc (left):

http://codereview.chromium.org/11049004/diff/2002/content/common/sandbox_poli...
content/common/sandbox_policy.cc:247: void
AddPluginDllEvictionPolicy(sandbox::TargetPolicy* policy) {
It seems the pepper plugin does not use this code so I think all code related to
PluginDllEviction can be removed, including the list.

http://codereview.chromium.org/11049004/diff/2002/content/common/sandbox_poli...
File content/common/sandbox_policy.cc (right):

http://codereview.chromium.org/11049004/diff/2002/content/common/sandbox_poli...
content/common/sandbox_policy.cc:713: if (!in_sandbox) {
we don't need to create policy (line 711) and then release it (line 714) now
that we don't have the SandboxPlugin call.

http://codereview.chromium.org/11049004/diff/2002/content/plugin/plugin_main.cc
File content/plugin/plugin_main.cc (left):

http://codereview.chromium.org/11049004/diff/2002/content/plugin/plugin_main....
content/plugin/plugin_main.cc:121: CoInitialize(NULL);
I am not sure about the CoInitialize removal, but if it works, great. Did I put
it there?

[brettw, 2012-10-04 19:20:06]

lgtm

[ananta, 2012-10-04 19:27:17]

lgtm

http://codereview.chromium.org/11049004/diff/2002/webkit/plugins/npapi/webplu...
File webkit/plugins/npapi/webplugin_delegate_impl.h (right):

http://codereview.chromium.org/11049004/diff/2002/webkit/plugins/npapi/webplu...
webkit/plugins/npapi/webplugin_delegate_impl.h:78: PLUGIN_QUIRK_EMULATE_IME =
131072,  // Windows.
Fix indent

[jschuh, 2012-10-04 22:14:52]

http://codereview.chromium.org/11049004/diff/2002/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_base.cc (left):

http://codereview.chromium.org/11049004/diff/2002/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_base.cc:152: if
(::GetPropW(orig_parent, webkit::npapi::kNativeWindowClassFilterProp)) {
On 2012/10/04 17:46:40, cpu wrote:
> the constant webkit::npapi::kNativeWindowClassFilterProp can be removed.

Done.

http://codereview.chromium.org/11049004/diff/2002/content/common/sandbox_poli...
File content/common/sandbox_policy.cc (left):

http://codereview.chromium.org/11049004/diff/2002/content/common/sandbox_poli...
content/common/sandbox_policy.cc:247: void
AddPluginDllEvictionPolicy(sandbox::TargetPolicy* policy) {
On 2012/10/04 17:46:40, cpu wrote:
> It seems the pepper plugin does not use this code so I think all code related
to
> PluginDllEviction can be removed, including the list.

Done.

http://codereview.chromium.org/11049004/diff/2002/content/common/sandbox_poli...
File content/common/sandbox_policy.cc (right):

http://codereview.chromium.org/11049004/diff/2002/content/common/sandbox_poli...
content/common/sandbox_policy.cc:713: if (!in_sandbox) {
On 2012/10/04 17:46:40, cpu wrote:
> we don't need to create policy (line 711) and then release it (line 714) now
> that we don't have the SandboxPlugin call.

Done.

http://codereview.chromium.org/11049004/diff/2002/content/plugin/plugin_main.cc
File content/plugin/plugin_main.cc (left):

http://codereview.chromium.org/11049004/diff/2002/content/plugin/plugin_main....
content/plugin/plugin_main.cc:121: CoInitialize(NULL);
On 2012/10/04 17:46:40, cpu wrote:
> I am not sure about the CoInitialize removal, but if it works, great. Did I
put
> it there?

Good call. I erroneously thought it was for IME warmup, but it turns out we've
always had it. I'll leave it behind to be safe.

http://codereview.chromium.org/11049004/diff/2002/webkit/plugins/npapi/webplu...
File webkit/plugins/npapi/webplugin_delegate_impl.h (right):

http://codereview.chromium.org/11049004/diff/2002/webkit/plugins/npapi/webplu...
webkit/plugins/npapi/webplugin_delegate_impl.h:78: PLUGIN_QUIRK_EMULATE_IME =
131072,  // Windows.
On 2012/10/04 19:27:17, ananta wrote:
> Fix indent

Done.

[commit-bot: I haz the power, 2012-10-04 22:19:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/11049004/28004

[commit-bot: I haz the power, 2012-10-05 02:44:17]

Change committed as 160310