Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 11048056: [Chromoting] The desktop process now connects back to the daemon process. (Closed)

Created:
8 years, 2 months ago by alexeypa (please no reviews)
Modified:
8 years, 2 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] The desktop process now connects back to the daemon process. BUG=134694 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162667

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR feedback and rebased on top of http://codereview.chromium.org/11028128/ #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -21 lines) Patch
M remoting/host/desktop_process.h View 1 chunk +22 lines, -2 lines 0 comments Download
M remoting/host/desktop_process.cc View 1 2 4 chunks +58 lines, -3 lines 0 comments Download
M remoting/host/desktop_session.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_exit_codes.h View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/win/host_service.cc View 1 2 5 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alexeypa (please no reviews)
PTAL.
8 years, 2 months ago (2012-10-12 18:55:32 UTC) #1
garykac
lgtm once comments are addressed http://codereview.chromium.org/11048056/diff/1/remoting/host/desktop_process.cc File remoting/host/desktop_process.cc (right): http://codereview.chromium.org/11048056/diff/1/remoting/host/desktop_process.cc#newcode103 remoting/host/desktop_process.cc:103: message_loop.Run(); Shouldn't this be ...
8 years, 2 months ago (2012-10-12 22:49:34 UTC) #2
alexeypa (please no reviews)
fyi http://codereview.chromium.org/11048056/diff/1/remoting/host/desktop_process.cc File remoting/host/desktop_process.cc (right): http://codereview.chromium.org/11048056/diff/1/remoting/host/desktop_process.cc#newcode103 remoting/host/desktop_process.cc:103: message_loop.Run(); On 2012/10/12 22:49:35, garykac wrote: > Shouldn't ...
8 years, 2 months ago (2012-10-16 19:47:01 UTC) #3
garykac
On 2012/10/16 19:47:01, alexeypa wrote: > On 2012/10/12 22:49:35, garykac wrote: > > Don't these ...
8 years, 2 months ago (2012-10-17 17:30:55 UTC) #4
alexeypa (please no reviews)
On 2012/10/17 17:30:55, garykac wrote: > On 2012/10/16 19:47:01, alexeypa wrote: > > On 2012/10/12 ...
8 years, 2 months ago (2012-10-18 05:13:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11048056/9002
8 years, 2 months ago (2012-10-18 05:13:29 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-18 07:15:20 UTC) #7
Change committed as 162667

Powered by Google App Engine
This is Rietveld 408576698