WebSocket test server migration on PPAPI tests

WebSocket test server migration on PPAPI tests

WebSocket test server migration from content::TestWebSocketServer to 
net::TestServer. 
This is a part of migration change for PPAPI tests.

BUG=137639
TEST=browser_tests --gtest_filter='*.WebSocket_*'

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162330

[Takashi Toyoshima, 2012-10-13 19:59:14]

Hi owners,
Could you take a look?

Viet-Trung, Yuzhu
Could you check pepper related files?
Usually, these files are reviewed by David.
But, he is in vacation now.
I think changes are trivial.

Ryan,
Could you review net stuff?
I also add OWNERS for net/data/websocket as a trial.
Do you think having WebSocket specific OWNERS file is effective?

[Takashi Toyoshima, 2012-10-16 01:11:17]

+brettw

ping.

[Ryan Sleevi, 2012-10-16 01:20:31]

I am not a good person to review the Python (although cursory inspection
suggests it looks good, it would be good to run this past someone with Python
readability or who has been involved in the Chromium-Python code)

As far as net/data/websocket/OWNERS, I think that's fine.

[Takashi Toyoshima, 2012-10-16 01:30:58]

+phajdan.jr for net/ python scripts.

Hi phajdan.jr,
I think you are familiar with network stuff, test tools, and python code.
Could you review readability on these python script?

[Paweł Hajdan Jr., 2012-10-16 17:01:26]

Sorry, I don't have Python readability ("yet"). One comment by the way.

http://codereview.chromium.org/11048050/diff/9001/net/data/websocket/close-co...
File net/data/websocket/close-code-and-reason_wsh.py (right):

http://codereview.chromium.org/11048050/diff/9001/net/data/websocket/close-co...
net/data/websocket/close-code-and-reason_wsh.py:1: # Copyright (c) 2012 The
Chromium Authors. All rights reserved.
Why is code in net/data? I think net/tools or net/test (depending on what it is)
would be better place.

[yzshen1, 2012-10-16 21:21:12]

file:.*ppapi.* LGTM

[Takashi Toyoshima, 2012-10-17 01:28:32]

On python files.

Thanks Paweł,
BTW, do you know a good person who has python readability, and is familiar with
net/tools stuff?

http://codereview.chromium.org/11048050/diff/9001/net/data/websocket/close-co...
File net/data/websocket/close-code-and-reason_wsh.py (right):

http://codereview.chromium.org/11048050/diff/9001/net/data/websocket/close-co...
net/data/websocket/close-code-and-reason_wsh.py:1: # Copyright (c) 2012 The
Chromium Authors. All rights reserved.
As you said, net/test/data is better place to have this kind of test data, and
other component follow that rule.
But, actually, we already have many resources for testing in net/data. So, I
just follow it in this series of CLs.

If we must have in net/test/data, we should make another refactoring change with
separated bug entry.

[Takashi Toyoshima, 2012-10-17 05:31:59]

I used pylint which depot_tools includes.
http://www.chromium.org/chromium-os/python-style-guidelines

I'll add bashi for net/data/websocket .

[bashi, 2012-10-17 05:46:53]

On 2012/10/17 05:31:59, Takashi Toyoshima (chromium) wrote:
> I used pylint which depot_tools includes.
> http://www.chromium.org/chromium-os/python-style-guidelines
> 
> I'll add bashi for net/data/websocket .

net/data/websocket LGTM.

[commit-bot: I haz the power, 2012-10-17 06:39:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/11048050/26008

[commit-bot: I haz the power, 2012-10-17 08:40:43]

Change committed as 162330

[Paweł Hajdan Jr., 2012-10-18 19:06:59]

On 2012/10/17 01:28:32, Takashi Toyoshima (chromium) wrote:
> If we must have in net/test/data, we should make another refactoring change
with
> separated bug entry.

Yes, please move any script out of net/data. Scripts are not data. :)

[Takashi Toyoshima, 2012-10-19 03:44:40]

*_wsh.py are script, but it works as a kind of CGI for HTTP.
Because these scripts are resource handler for WebSocket.
So, I believe here is the right path to exist.

Rephrasing it, an access to 'ws://127.0.0.1:<random port>/echo/' is handled by
net/data/websocket/echo_wsh.py and http://127.0.0.1:<random
port>/connect_check.html' is handled by net/data/websocket/connect_check.html.

Note: If we relocate net/data itself, it will be a big cost. Currently, there
are many customized test infrastructures which has minimum set of checkout.
Changing this kind of path breaks many things.