Allow settings dialog to be opened via the app launcher, as a packaged app.

Allow settings dialog to be opened via the app launcher, as a packaged app.

This first stage fixes peculiar behaviour when running a launched ShellWindow 
in a process separate from the background page (e.g. sandboxed pages, and the 
new settings app, which will use a process running WebUI), as well as 
installing the app itself; loading the vanillla chrome://settings pages.

Next part: theming and pages for the app-host settings UI.

BUG=130210
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161828

[tapted, 2012-10-12 02:44:57]

@sky, can you assist with a review for small parts in chrome/browser/ui,
chrome/browser/tab_contents, and changes for resources/assets?

@benwells for chrome/browser/extensions

Note that this is initially targeting only windows, where the (chromeos-like)
app launcher is present, to provide a way to configure chrome settings when
there is no browser ("app host" mode).

[sky, 2012-10-12 16:30:21]

LGTM

https://codereview.chromium.org/11048045/diff/9002/chrome/browser/ui/extensio...
File chrome/browser/ui/extensions/shell_window.cc (right):

https://codereview.chromium.org/11048045/diff/9002/chrome/browser/ui/extensio...
chrome/browser/ui/extensions/shell_window.cc:140: == params.creator_process_id)
{
== on previous line.

https://codereview.chromium.org/11048045/diff/9002/chrome/browser/ui/extensio...
chrome/browser/ui/extensions/shell_window.cc:143: DLOG(INFO) << "ShellWindow
created in new process ("
VLOG

[benwells, 2012-10-15 02:04:42]

lgtm with baby nits

http://codereview.chromium.org/11048045/diff/9002/chrome/browser/extensions/c...
File chrome/browser/extensions/component_loader.cc (right):

http://codereview.chromium.org/11048045/diff/9002/chrome/browser/extensions/c...
chrome/browser/extensions/component_loader.cc:376: if
(CommandLine::ForCurrentProcess()
nit: indent like this:
  if (CommandLine::ForCurrentProcess()->HasSwitch(
__________switches::kEnableSettingsApp)) {
^ 10 spaces
    Add(....

http://codereview.chromium.org/11048045/diff/9002/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/11048045/diff/9002/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:637: const char kEnableSettingsApp[]           
        = "enable-settings-app";
Nit: = should line up with other lines

[tapted, 2012-10-15 02:32:39]

http://codereview.chromium.org/11048045/diff/9002/chrome/browser/extensions/c...
File chrome/browser/extensions/component_loader.cc (right):

http://codereview.chromium.org/11048045/diff/9002/chrome/browser/extensions/c...
chrome/browser/extensions/component_loader.cc:376: if
(CommandLine::ForCurrentProcess()
On 2012/10/15 02:04:42, benwells wrote:
> nit: indent like this:
>   if (CommandLine::ForCurrentProcess()->HasSwitch(
> __________switches::kEnableSettingsApp)) {
> ^ 10 spaces
>     Add(....

Done.

http://codereview.chromium.org/11048045/diff/9002/chrome/browser/ui/extension...
File chrome/browser/ui/extensions/shell_window.cc (right):

http://codereview.chromium.org/11048045/diff/9002/chrome/browser/ui/extension...
chrome/browser/ui/extensions/shell_window.cc:140: == params.creator_process_id)
{
On 2012/10/12 16:30:21, sky wrote:
> == on previous line.

Done.

http://codereview.chromium.org/11048045/diff/9002/chrome/browser/ui/extension...
chrome/browser/ui/extensions/shell_window.cc:143: DLOG(INFO) << "ShellWindow
created in new process ("
On 2012/10/12 16:30:21, sky wrote:
> VLOG

Done.

http://codereview.chromium.org/11048045/diff/9002/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/11048045/diff/9002/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:637: const char kEnableSettingsApp[]           
        = "enable-settings-app";
On 2012/10/15 02:04:42, benwells wrote:
> Nit: = should line up with other lines

Done. (..not even sure where that came from -- might be my mergetool editor
converted some whitespace to/from tabs).

[commit-bot: I haz the power, 2012-10-15 03:23:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/11048045/22004

[commit-bot: I haz the power, 2012-10-15 03:23:32]

Presubmit check for 11048045-22004 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\) )?(2012|2011|2010|2009|2008|2007|2006|2006-2008) The
Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  chrome/browser/resources/settings_app/settings_app.js

Presubmit checks took 1.6s to calculate.

[commit-bot: I haz the power, 2012-10-15 03:43:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/11048045/21022

[jeremya, 2012-10-15 04:11:16]

(lgtm)

[commit-bot: I haz the power, 2012-10-15 05:48:13]

Change committed as 161828