Move IPCMessageStart enum into it own directory with security team OWNERS, so that new message file…

Move IPCMessageStart enum into it own file with security team OWNERS, so that new message files can't be added to chromium without triggering a security review.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163713

[jam, 2012-10-11 23:19:59]

lgtm

[jschuh, 2012-10-12 00:00:15]

lgtm

[Tom Sepez, 2012-10-12 00:41:40]

Gonna hold off in light of https://codereview.chromium.org/11114005/ which may
prevent the need for the sub-directories.

[commit-bot: I haz the power, 2012-10-16 22:01:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/11048038/1

[Tom Sepez, 2012-10-16 22:01:12]

On 2012/10/12 00:41:40, Tom Sepez wrote:
> Gonna hold off in light of https://codereview.chromium.org/11114005/ which may
> prevent the need for the sub-directories.

Gonna commit in light of the above stalling.  No worries.

[Tom Sepez, 2012-10-16 22:57:56]

Gonna uncheck commit in light of the above moving again.

[Tom Sepez, 2012-10-17 22:00:33]

+dpranke for review of ipc/OWNERS syntax.

[Dirk Pranke, 2012-10-17 22:01:11]

yup, the OWNERS syntax looks right.

[commit-bot: I haz the power, 2012-10-17 23:00:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/11048038/21001

[commit-bot: I haz the power, 2012-10-17 23:00:43]

Presubmit check for 11048038-21001 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1258, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1106, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1023, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 576, in CheckChangeOnCommit
  File "<string>", line 478, in _CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 941, in
PanProjectChecks
    input_api, output_api, source_file_filter=None))
  File "/b/depot_tools/presubmit_canned_checks.py", line 778, in CheckOwners
    reviewers_plus_owner)
  File "/b/depot_tools/owners.py", line 91, in directories_not_covered_by
    self._load_data_needed_for(files)
  File "/b/depot_tools/owners.py", line 137, in _load_data_needed_for
    self._read_owners_in_dir(dirpath)
  File "/b/depot_tools/owners.py", line 165, in _read_owners_in_dir
    'or an email address: "%s"' % line))
owners.SyntaxErrorInOwnersFile: /b/commit-queue/workdir/chromium/ipc/OWNERS:12
syntax error: line is not a comment, a "set" directive, or an email address:
"per-file ipc_message_start.h=set noparent"

[Dirk Pranke, 2012-10-17 23:10:49]

On 2012/10/17 23:00:43, I haz the power (commit-bot) wrote:
> Presubmit check for 11048038-21001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> Traceback (most recent call last):
>   File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
>     sys.exit(presubmit_support.Main(argv))
>   File "/b/depot_tools/presubmit_support.py", line 1258, in Main
>     rietveld_obj)
>   File "/b/depot_tools/presubmit_support.py", line 1106, in DoPresubmitChecks
>     results += executer.ExecPresubmitScript(presubmit_script, filename)
>   File "/b/depot_tools/presubmit_support.py", line 1023, in
ExecPresubmitScript
>     result = eval(function_name + '(*__args)', context)
>   File "<string>", line 1, in <module>
>   File "<string>", line 576, in CheckChangeOnCommit
>   File "<string>", line 478, in _CommonChecks
>   File "/b/depot_tools/presubmit_canned_checks.py", line 941, in
> PanProjectChecks
>     input_api, output_api, source_file_filter=None))
>   File "/b/depot_tools/presubmit_canned_checks.py", line 778, in CheckOwners
>     reviewers_plus_owner)
>   File "/b/depot_tools/owners.py", line 91, in directories_not_covered_by
>     self._load_data_needed_for(files)
>   File "/b/depot_tools/owners.py", line 137, in _load_data_needed_for
>     self._read_owners_in_dir(dirpath)
>   File "/b/depot_tools/owners.py", line 165, in _read_owners_in_dir
>     'or an email address: "%s"' % line))
> owners.SyntaxErrorInOwnersFile: /b/commit-queue/workdir/chromium/ipc/OWNERS:12
> syntax error: line is not a comment, a "set" directive, or an email address:
> "per-file ipc_message_start.h=set noparent"

Looks like the try servers maybe don't have the latest version of depot_tools
yet ...

[commit-bot: I haz the power, 2012-10-23 18:13:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/11048038/21001

[commit-bot: I haz the power, 2012-10-23 19:13:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/11048038/35001

[commit-bot: I haz the power, 2012-10-23 23:03:37]

Change committed as 163713