OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for isolate. | 5 """Top-level presubmit script for isolate. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for |
8 details on the presubmit API built into gcl. | 8 details on the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
11 | 11 |
12 def CommonChecks(input_api, output_api): | 12 def CommonChecks(input_api, output_api): |
13 output = [] | 13 output = [] |
14 disabled_warnings = [ | 14 disabled_warnings = [ |
15 'F0401', # Unable to import module | 15 'F0401', # Unable to import module |
16 'R0401', # Cyclic import | 16 'R0401', # Cyclic import |
17 'W0613', # Unused argument | 17 'W0613', # Unused argument |
18 'E1103', # subprocess.communicate() generates these :( | 18 'E1103', # subprocess.communicate() generates these :( |
19 'R0201', # method could be function (doesn't reference self) | 19 'R0201', # method could be function (doesn't reference self) |
20 ] | 20 ] |
21 black_list = [r'src/build_tools/tests/.*', | 21 black_list = [r'src[\\\/]build_tools[\\\/]tests[\\\/].*'] |
22 r'src/site_scons/.*', | |
23 ] | |
24 canned = input_api.canned_checks | 22 canned = input_api.canned_checks |
25 output.extend(canned.RunPylint(input_api, output_api, black_list=black_list, | 23 output.extend(canned.RunPylint(input_api, output_api, black_list=black_list, |
26 disabled_warnings=disabled_warnings)) | 24 disabled_warnings=disabled_warnings)) |
27 return output | 25 return output |
28 | 26 |
29 | 27 |
30 def CheckChangeOnUpload(input_api, output_api): | 28 def CheckChangeOnUpload(input_api, output_api): |
31 return CommonChecks(input_api, output_api) | 29 return CommonChecks(input_api, output_api) |
32 | 30 |
33 | 31 |
34 def CheckChangeOnCommit(input_api, output_api): | 32 def CheckChangeOnCommit(input_api, output_api): |
35 return CommonChecks(input_api, output_api) | 33 return CommonChecks(input_api, output_api) |
36 | 34 |
37 | 35 |
38 def GetPreferredTrySlaves(project, change): | 36 def GetPreferredTrySlaves(project, change): |
39 return ['linux_nacl_sdk', 'win_nacl_sdk', 'mac_nacl_sdk'] | 37 return ['linux_nacl_sdk', 'win_nacl_sdk', 'mac_nacl_sdk'] |
OLD | NEW |