Browser Plugin: Implement terminate()

Browser Plugin: Implement terminate()

BUG=153532
Test=BrowserPluginHostTest.TerminateGuest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160057

[Charlie Reis, 2012-10-03 19:10:16]

https://codereview.chromium.org/11048023/diff/2001/content/browser/browser_pl...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/11048023/diff/2001/content/browser/browser_pl...
content/browser/browser_plugin/browser_plugin_guest.cc:92:
base::KillProcess(process_handle, RESULT_CODE_KILLED, false);
This needs a UMA stat, like the ones Sadrul is adding.  Do you want to do that
here or have Sadrul do it separately?

https://codereview.chromium.org/11048023/diff/2001/content/browser/browser_pl...
File content/browser/browser_plugin/browser_plugin_host_browsertest.cc (right):

https://codereview.chromium.org/11048023/diff/2001/content/browser/browser_pl...
content/browser/browser_plugin/browser_plugin_host_browsertest.cc:613: //
Override the hang timeout for guest to be very small.
Why is a shorter hang timeout needed?  It should crash immediately, right?

[Fady Samuel, 2012-10-03 19:26:05]

https://codereview.chromium.org/11048023/diff/2001/content/browser/browser_pl...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/11048023/diff/2001/content/browser/browser_pl...
content/browser/browser_plugin/browser_plugin_guest.cc:92:
base::KillProcess(process_handle, RESULT_CODE_KILLED, false);
On 2012/10/03 19:10:16, creis wrote:
> This needs a UMA stat, like the ones Sadrul is adding.  Do you want to do that
> here or have Sadrul do it separately?

Added.

https://codereview.chromium.org/11048023/diff/2001/content/browser/browser_pl...
File content/browser/browser_plugin/browser_plugin_host_browsertest.cc (right):

https://codereview.chromium.org/11048023/diff/2001/content/browser/browser_pl...
content/browser/browser_plugin/browser_plugin_host_browsertest.cc:613: //
Override the hang timeout for guest to be very small.
On 2012/10/03 19:10:16, creis wrote:
> Why is a shorter hang timeout needed?  It should crash immediately, right?

Copy-and-paste error. :P Removed.

[Charlie Reis, 2012-10-03 19:54:43]

LGTM.

[commit-bot: I haz the power, 2012-10-03 21:01:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11048023/9001

[commit-bot: I haz the power, 2012-10-03 21:01:24]

Presubmit check for 11048023-9001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.3s to calculate.

[Fady Samuel, 2012-10-03 21:02:49]

+sky for chrome OWNER

[sky, 2012-10-03 21:17:55]

LGTM

[commit-bot: I haz the power, 2012-10-03 23:33:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11048023/9001

[commit-bot: I haz the power, 2012-10-03 23:33:31]

Failed to apply patch for chrome/tools/chromeactions.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/tools/chromeactions.txt
  Hunk #1 FAILED at 195.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/tools/chromeactions.txt.rej

Patch:       chrome/tools/chromeactions.txt
Index: chrome/tools/chromeactions.txt
diff --git a/chrome/tools/chromeactions.txt b/chrome/tools/chromeactions.txt
index
33476fe07c91a53bd0ce69372764adbb4ab5968c..8dee6012f86924bd6e8164a3475165a5b6e38dab
100644
--- a/chrome/tools/chromeactions.txt
+++ b/chrome/tools/chromeactions.txt
@@ -195,6 +195,7 @@
 0xc7c989d7aa14f64d	BookmarkManager_Sync
 0xec92650848f88dda	BookmarkMenu_clicked
 0xd1cd299109c75a4c	Bookmarks_Search
+0x7784cf1f8b1cc3f0	BrowserPlugin.Guest.Terminate
 0xea4788705e6873b4	Cancel
 0x89394b102e55da81	ClearAuthenticationCache
 0x6bd5f5b094096aa7	ClearBrowsingData_Autofill

[commit-bot: I haz the power, 2012-10-04 00:47:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11048023/13001

[commit-bot: I haz the power, 2012-10-04 02:43:23]

Change committed as 160057