subprocess2.py - Issue 11046016: Correct invalid use of 'is' when '==' should have been used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: subprocess2.py

Issue 11046016: Correct invalid use of 'is' when '==' should have been used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: subprocess2.py

diff --git a/subprocess2.py b/subprocess2.py

index 043194f47c5690a12a72c2d02c3ec9c06cd99650..364aace886009ab18322524f6e8f8bc6f97a03d3 100644

--- a/subprocess2.py

+++ b/subprocess2.py

@@ -295,9 +295,9 @@ class Popen(subprocess.Popen):

# This thread needs to be optimized for speed.

while threads:

item = queue.get()

- if item[0] is 'stdout':

+ if item[0] == 'stdout':

self.stdout_cb(item[1])

- elif item[0] is 'stderr':

+ elif item[0] == 'stderr':

self.stderr_cb(item[1])

else:

# A thread terminated.

« no previous file with comments | « gclient.py ('k') | no next file » | no next file with comments »