Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 11046009: Remove hidebookmarkbubbleview known reliability crash. (Closed)

Created:
8 years, 2 months ago by msw
Modified:
8 years, 2 months ago
Reviewers:
dmazzoni, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Remove hidebookmarkbubbleview known reliability crash. Only two crash reports exist for browser::HideBookmarkBubbleView(). https://crash.corp.google.com/search?query=HideBookmarkBubbleView https://crash.corp.google.com/reportdetail?reportid=850c8c208ae05e28 https://crash.corp.google.com/reportdetail?reportid=d115f9e1ecff21fd Both were 19.0.1084.56, so this seems like an old issue that was fixed. Still, this is just a speculative change, failures may resurface. BUG=96235 TEST=no reliability crashes in hidebookmarkbubbleview. TBR=dmazzoni@chromium.org,sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/test/data/reliability/known_crashes.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/11046009/1
8 years, 2 months ago (2012-10-02 22:23:30 UTC) #1
jamesr
Anyone know why cc-bugs@chromium.org is cc'd on this?
8 years, 2 months ago (2012-10-02 22:28:06 UTC) #2
sky
LGTM
8 years, 2 months ago (2012-10-02 22:39:55 UTC) #3
commit-bot: I haz the power
List of reviewers changed. jamesr@chromium.org did a drive-by without LGTM'ing!
8 years, 2 months ago (2012-10-03 01:18:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/11046009/1
8 years, 2 months ago (2012-10-03 01:44:58 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-03 01:45:20 UTC) #6
Change committed as 159828

Powered by Google App Engine
This is Rietveld 408576698