Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trychange.py

Issue 11046004: Added extra error message to trychange for empty diffs (Closed) Base URL: https://git.chromium.org/chromium/tools/depot_tools.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index 73c81ee543f482f0723bdb5662540e9a0362d839..a1403526e502d0d992b3f6fd9879cf3c1b60979b 100755
--- a/trychange.py
+++ b/trychange.py
@@ -777,6 +777,7 @@ def TryChange(argv,
for checkout in checkouts:
raw_diff = checkout.GenerateDiff()
if not raw_diff:
+ logging.error('Empty or non-existant diff, exiting.')
return 1
diff = raw_diff.splitlines(True)
path_diff = gclient_utils.PathDifference(root, checkout.checkout_root)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698