Give Chrome Web Store app an icon in its manifest file.

Give Chrome Web Store app an icon in its manifest file.

This fixes no icon being shown in the "The app is currently unreachable" page for the chrome web store.
Also added is another exception to ResourceRequestPolicy::CanRequestResource to make sure the error
page is always allowed to display the app's icon, even in a manifest v2 app that doesn't list its
icons in web_accessible_resources.

This time without the nondeterministic compile failures http://codereview.chromium.org/10985028/
caused by depending on browser/ grit files from common/ code.

BUG=135549
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160143

[Marijn Kruisselbrink, 2012-10-03 23:06:40]

Please review this again;
The only change in this compared to the previous CL is that I moved
IsComponentExtensionResource back from extension_file_util to
ImageLoadingTracker. This method depends on a grit/ file that is generated from
browser/ so having code in common/ depend on that caused random compile
failures.

[Aaron Boodman, 2012-10-04 04:39:24]

lgtm

On Wed, Oct 3, 2012 at 4:06 PM,  <mek@chromium.org> wrote:
> Reviewers: Aaron Boodman, James Hawkins,
>
> Message:
> Please review this again;
> The only change in this compared to the previous CL is that I moved
> IsComponentExtensionResource back from extension_file_util to
> ImageLoadingTracker. This method depends on a grit/ file that is generated
> from
> browser/ so having code in common/ depend on that caused random compile
> failures.
>
> Description:
> Give Chrome Web Store app an icon in its manifest file.
>
> This fixes no icon being shown in the "The app is currently unreachable"
> page
> for the chrome web store.
> Also added is another exception to ResourceRequestPolicy::CanRequestResource
> to
> make sure the error
> page is always allowed to display the app's icon, even in a manifest v2 app
> that
> doesn't list its
> icons in web_accessible_resources.
>
> This time without the nondeterministic compile failures
> http://codereview.chromium.org/10985028/
> caused by depending on browser/ grit files from common/ code.
>
> BUG=135549
>
>
> Please review this at http://codereview.chromium.org/11045030/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M chrome/browser/extensions/extension_icon_image.cc
>   M chrome/browser/extensions/extension_protocols.cc
>   M chrome/browser/extensions/image_loading_tracker.h
>   M chrome/browser/extensions/image_loading_tracker.cc
>   M chrome/browser/extensions/image_loading_tracker_unittest.cc
>   M chrome/browser/resources/chrome_app/manifest.json
>   M chrome/browser/resources/webstore_app/manifest.json
>   M chrome/browser/ui/webui/extensions/extension_icon_source.cc
>   M chrome/renderer/extensions/resource_request_policy.cc
>
>

[James Hawkins, 2012-10-04 13:36:43]

lgtm

[commit-bot: I haz the power, 2012-10-04 14:10:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mek@chromium.org/11045030/1

[commit-bot: I haz the power, 2012-10-04 16:19:40]

Change committed as 160143