Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 11045021: Honor mmintrin.h intrinics when instrumenting Chrome with cygprofiler. (Closed)

Created:
8 years, 2 months ago by glotov
Modified:
8 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Honor mmintrin.h intrinics when instrumenting Chrome with cygprofiler. BUG=chromium-os:35028 TEST=build chrome with GYP_DEFINES="order_profiling=1" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -42 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M media/media.gyp View 2 chunks +0 lines, -14 lines 0 comments Download
M skia/skia.gyp View 4 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
glotov
Hi! Please have a look.
8 years, 2 months ago (2012-10-03 14:55:53 UTC) #1
Jeff Timanus
On 2012/10/03 14:55:53, glotov wrote: > Hi! Please have a look. As I understand things, ...
8 years, 2 months ago (2012-10-03 15:10:59 UTC) #2
glotov
Hi! Need your owner approval.
8 years, 2 months ago (2012-10-04 07:57:44 UTC) #3
Dmitry Polukhin
LGTM
8 years, 2 months ago (2012-10-04 08:15:03 UTC) #4
scherkus (not reviewing)
media lgtm
8 years, 2 months ago (2012-10-04 20:49:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11045021/1
8 years, 2 months ago (2012-10-05 07:30:12 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-05 09:31:46 UTC) #7
Change committed as 160341

Powered by Google App Engine
This is Rietveld 408576698