Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 11044027: Add Android UMA actions to chromeactions.txt (Closed)

Created:
8 years, 2 months ago by gone
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Ilya Sherman, MAD, pam+watch_chromium.org, jar (doing other things)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add Android UMA actions to chromeactions.txt There are actions that are pulled from a different repo and aren't normally crawled by the extract_actions.py script. Manually add them to extract_actions.py. TBR=jam@chromium.org BUG=136984 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160056

Patch Set 1 #

Patch Set 2 : Adding TBR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -0 lines) Patch
M chrome/tools/chromeactions.txt View 2 chunks +75 lines, -0 lines 0 comments Download
M chrome/tools/extract_actions.py View 2 chunks +83 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gone
Hey jam, We use these metric names on Android but don't (currently?) have a way ...
8 years, 2 months ago (2012-10-03 23:53:19 UTC) #1
Ilya Sherman
Drive-by LGTM. Thanks for adding these!
8 years, 2 months ago (2012-10-04 00:14:21 UTC) #2
Isaac (away)
++
8 years, 2 months ago (2012-10-04 00:27:01 UTC) #3
gone
Turns out we need this to fix our dashboards. TBRing jam@.
8 years, 2 months ago (2012-10-04 00:43:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/11044027/4002
8 years, 2 months ago (2012-10-04 00:45:35 UTC) #5
nilesh
LGTM
8 years, 2 months ago (2012-10-04 01:02:23 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-04 02:35:48 UTC) #7
Change committed as 160056

Powered by Google App Engine
This is Rietveld 408576698