Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/ui/views/constrained_window_views_browsertest.cc

Issue 11044020: Make Web Intents picker in Views conform to latest mocks (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Add a .cc file for constants to be able to compile in debug mode Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/constrained_window_views_browsertest.cc
diff --git a/chrome/browser/ui/views/constrained_window_views_browsertest.cc b/chrome/browser/ui/views/constrained_window_views_browsertest.cc
index 82c00027ebe6c917373982da442fd8b9e888c1bc..c98a4a3b86e3c227a46a7f5be59dec688b03e3b0 100644
--- a/chrome/browser/ui/views/constrained_window_views_browsertest.cc
+++ b/chrome/browser/ui/views/constrained_window_views_browsertest.cc
@@ -114,8 +114,9 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, FocusTest) {
// Create a constrained dialog. It will attach itself to tab_contents.
scoped_ptr<TestConstrainedDialog> test_dialog1(new TestConstrainedDialog);
- ConstrainedWindowViews* window1 =
- new ConstrainedWindowViews(web_contents, test_dialog1.get(), false);
+ ConstrainedWindowViews* window1 = new ConstrainedWindowViews(
+ web_contents, test_dialog1.get(), false,
+ ConstrainedWindowViews::DEFAULT_INSETS);
views::FocusManager* focus_manager = window1->GetFocusManager();
ASSERT_TRUE(focus_manager);
@@ -128,8 +129,9 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, FocusTest) {
// tab_contents, but will remain hidden since the test_dialog1 is still
// showing.
scoped_ptr<TestConstrainedDialog> test_dialog2(new TestConstrainedDialog);
- ConstrainedWindowViews* window2 =
- new ConstrainedWindowViews(web_contents, test_dialog2.get(), false);
+ ConstrainedWindowViews* window2 = new ConstrainedWindowViews(
+ web_contents, test_dialog2.get(), false,
+ ConstrainedWindowViews::DEFAULT_INSETS);
// Should be the same focus_manager.
ASSERT_EQ(focus_manager, window2->GetFocusManager());
@@ -186,8 +188,9 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, TabCloseTest) {
// Create a constrained dialog. It will attach itself to tab_contents.
scoped_ptr<TestConstrainedDialog> test_dialog(new TestConstrainedDialog);
- ConstrainedWindowViews* window =
- new ConstrainedWindowViews(web_contents, test_dialog.get(), true);
+ ConstrainedWindowViews* window = new ConstrainedWindowViews(
+ web_contents, test_dialog.get(), true,
+ ConstrainedWindowViews::DEFAULT_INSETS);
bool closed =
browser()->tab_strip_model()->CloseTabContentsAt(

Powered by Google App Engine
This is Rietveld 408576698